Comments (7)
I had a quick look over the source code, seems easy. However, some questions as I'm not familiar with python
Can the python code already read values fromSeems to be theetc/mailinabox.conf
?env
variable.- I think adding a
DKIM_SELECTOR=mail
as default - The PR will likely touch 2 scripts,
test_dns.py
anddns_update.py
, ok?
from mailinabox.
I have some commits here main...bilogic:mailinabox:custom-dkim-selector, apologies that it is mixed in with a configurable TTL feature.
The main change is on line 792 of dns_update.py
where I replaced mail
with {selector}
My problem is, why does the /admin#external_dns
still show mail._domainkey...
? Where is the code to make the page reflect the custom selector?
from mailinabox.
#2220 replaces OpenDKIM with dkimpy. My recommendation would be to work with @kiekerjan as your changes seem reasonable to me as I have issues with using mail
as a selector because there are commercial services using the same selector so there is a potential to be in conflict. Better would be either configurable selector or at least something unique.
Then, ideally, this stimulates getting the PR merged.
from mailinabox.
Look at the dkim.sh script in the setup directory. There the default dns entry is generated.
Because this is done only at initial setup, you need to include some logic to generate a new mail.txt on every run of the setup, or include generating the dns record in dns_update.py
Also, in start.sh you might want to use something like DKIM_SELECTOR=${DEFAULT_DKIM_SELECTOR:-mail} Your current code will always use mail as selector (and overwrite anything else)
from mailinabox.
Just finished a hardware migration. Thank you for the info, let me find some time to review them.
But 1 quick qn first, is the maintainer open to accepting dkimpy first?
from mailinabox.
python and bash are like my 5th language 🤣
Definitely configurable (and not just something different). Since we are going to change it, let's provide an end-all solution. From the looks of it, this is not a very big change here, so if and when we switch to dkimpy, I would be happy to help.
I'm thinking of asking for a selector at initial setup and it should not be touched again, trying to accomplish this with minimum code rather than introduce the same logic in different parts of the code, or do you have some ideas? Do share!The use of DEFAULT_DKIM_SELECTOR feels sufficiently configurable yet simple to me (aligned with aims of MIAB). What do you think?I made the change inAll lines in an existingstart.sh
, but where does$DEFAULT_DKIM_SELECTOR
come from?mailinbox.conf
are prefixed withDEFAULT_
Thanks!
from mailinabox.
My new branch with the key bits here b51550d
Please help me to review. Thank you.
from mailinabox.
Related Issues (20)
- SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports HOT 4
- Mailinabox discourse is down? HOT 1
- Weird output (from Roundcube?) during install HOT 2
- Update to SpamAssassin 4 HOT 2
- hostname example.host.tld does not resolve to address xxx.xxx.xxx.xxx HOT 4
- Fail2ban - miab-munin.conf filter not cathing HTTP/2.0
- Add an edit button on DNS entries
- LetsEncrypt certificate renewal fails
- Systemd service not working
- how make a file copy of incoming email?
- Backup Error happening with mailinabox command I think HOT 1
- Break System Status Checks up into smaller checks HOT 2
- Root Domain configs in nginx
- owncloud-unlockadmin.sh has incorrect path for mail.py HOT 5
- Backup: File size can't be validated, because of missing capabilities of the backend HOT 5
- freebsd support HOT 2
- active-sync is with imap, or with mapi
- Multiple Domain why change NS ?? HOT 3
- Feature request: Add the ability for parked domain email user to edit it's own DNS records in the control panel HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailinabox.