safe node run-baby-fleming fails to start any nodes about temp_safe_network HOT 9 CLOSED

If the parameter can just be removed I'll try this and be happy to submit a PR.

from temp_safe_network.

I believe @jacderida will be having a look at the node bin shortly, so hopefully he can take a look at this 🙇

from temp_safe_network.

👎 I was looking in the code to see where this is being set and didn't find it yet. I see where the launch tool would do this, but only if it is first passed the same parameter. I don't see what is passing that though 🤷‍♂️

from temp_safe_network.

I couldn't reproduce this on main with the following:

$ cargo run --release --bin=safe -- node install
$ cargo run --release --bin=safe -- node run-baby-fleming

Not sure if this was fixed or it's an issue with the binaries that were released.

from temp_safe_network.

What sn_node version is that? I still can't do safe update because it gives a 404 error but I did safe node update which updated my sn_node to v0.75.0 and still get the error.

Wondering if this is a path issue I've tried a few variations (including safe node bin-version / safe node run-baby-fleming and /home/mrh/.safe/node/sn_node run-baby-fleming) but they still give version v0.75.0 and the following error:

safe node run-baby-fleming
Storing nodes' generated data at /home/mrh/.safe/node/baby-fleming-nodes
Starting nodes to join the Safe network...
error: Found argument '--skip-auto-port-forwarding' which wasn't expected, or isn't valid in this context

	If you tried to supply `--skip-auto-port-forwarding` as a value rather than a flag, use `-- --skip-auto-port-forwarding`

USAGE:
    sn_node --verbose

For more information try --help
Error: 
   0: Error launching node
   1: Failed to start '/home/mrh/.safe/node/sn_node' with args '["-vv", "--skip-auto-port-forwarding", "--local-addr", "127.0.0.1:0", "--first", "--root-dir", "/home/mrh/.safe/node/baby-fleming-nodes/sn-node-genesis", "--log-dir", "/home/mrh/.safe/node/baby-fleming-nodes/sn-node-genesis"]'
   2: Node exited early (status: exit status: 2)

Location:
   /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/sn_launch_tool-0.12.1/src/cmd.rs:163

Is there something else I can try?

from temp_safe_network.

Sorry, I just noticed my name on this.

Yeah, I should be taking a look at various usability issues starting either today or tomorrow, so I'm happy to take ownership of this too.

The --skip-auto-port-forwarding flag has been removed now.

from temp_safe_network.

Do you know what is inserting it? I'm not giving it!

Maybe the issue is that I can't use safe update (gives a 404) and that the last script installed CLI is too old? I have sn_cli 0.69.1.

from temp_safe_network.

It's probably coming from the node run-baby-fleming command. I'll look into it in more detail soon, as well as self update.

from temp_safe_network.

The node command has now been removed from safe and the recommended way to create local test networks is to use the testnet binary.

There haven't been any reported issues with testnet.

Going to close this.

from temp_safe_network.