Giter Club home page Giter Club logo

Comments (9)

IzzySoft avatar IzzySoft commented on September 15, 2024 1

OK, just triggered a fastlane pull. Your update will show up then with the next sync around 7 pm UTC. Thanks a lot!

from colorblendr.

Mahmud0808 avatar Mahmud0808 commented on September 15, 2024

It is because in the latest material components library v1.11.0+, apps don't follow system colors anymore. They now need to be individually themed. So ColorBlendr shows the list of all installed apps and if user has some apps which are monet themed but still not following system colors, they will need to select it and it will be themed instantly.

Related explanation (shown in-app too): strings.xml#L114
Related issues (resolved): #5

from colorblendr.

IzzySoft avatar IzzySoft commented on September 15, 2024

Ah, thanks! May I suggest to point this out in the app description as well (not necessarily the permission itself, but at least that it needs to access and show a list of all apps) so the question won't resurface every once? Some people prefer to know before installing, so they won't see it "in-app". Even providing a screenshot of it showing the apps would do, though then is the risk nobody remembers why this specific screenshot is needed and it might get replaced with something else one day.

from colorblendr.

IzzySoft avatar IzzySoft commented on September 15, 2024

PS, that clarified: the app really needs to access ALL storage, like a file manager does? Asking because of android.permission.MANAGE_EXTERNAL_STORAGE.

from colorblendr.

Mahmud0808 avatar Mahmud0808 commented on September 15, 2024

May I suggest to point this out in the app description as well

README or fastlane project description?

the app really needs to access ALL storage, like a file manager does?

Yes. To generate colors from wallpaper, it needs to grab the wallpaper first. And without this permission it will throw error.

from colorblendr.

IzzySoft avatar IzzySoft commented on September 15, 2024

README or fastlane project description?

At least Fastlane (which is what will be shown in the F-Droid clients later). README cannot hurt either, for everyone else. Speaking of Fastlane and F-Droid: You might wish to add a FUNDING.yml to your .github directory for your donation links. F-Droid will pick that up along with Fastlane.

And also btw Fastlane: featureGraphic dimensions should be either 1024x500 or 512x250, yours is 4096x1440 and thus does not even have the correct proportions (it also gives another warning: "libpng warning: iCCP: known incorrect sRGB profile"). Not a real stopper, but might look weird in some places.

(storage) Thanks! Then all should be fine. Not just for your RFP, your app just passed all other tests here for my repo, too, and will show up in my repo with the next sync in less than two hours from now.

Feel free to close this issue if you think all has been addressed – or do so after adjusting featureGraphic and FUNDING.yml if you prefer 😉 Thanks a lot!

from colorblendr.

Mahmud0808 avatar Mahmud0808 commented on September 15, 2024

I will close this issue after resolving all and also will try to find alternative permissions for getting wallpaper (not sure if there is any). Thanks for the help btw.

Edit: Unfortunately because of scoped storage, no other permission can help in retrieving current device wallpaper. Other issues have been resolved.

from colorblendr.

IzzySoft avatar IzzySoft commented on September 15, 2024

I've put those two permissions on the positive-list (so scans on future updates won't raise alerts here). F-Droid itself (where you applied for inclusion) does not scan for those on updates (yet), only on inclusion (I've sent a note with the details to LK, so the team is aware this was already addressed).

Thanks for updating Fastlane details! Is there any new release scheduled soon, or should I manually trigger a fastlane update here so it gets into my repo? On new releases it will be pulled along automatically.

from colorblendr.

Mahmud0808 avatar Mahmud0808 commented on September 15, 2024

There is no new release scheduled for now. And thanks for the heads-up.

from colorblendr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.