Comments (8)
With Steve's blessing, I vote we drop support for 23, since that will give us some decent improvements.
from s.el.
I think it's 100% fine to not support Emacs 23. I think at this stage you could also reasonably drop Emacs 24, to be honest, if it causes any extra maintainer overhead here. The last 24.x release was 2015-04-10, almost 7.5 years ago.
from s.el.
@magnars - should consider when updating Travis/CI.
from s.el.
s.el
is a library that is being used by lots of packages and lots of people, so I am wary of dropping support of older Emacsen. However, maybe Emacs 23 is old enough to warrant it regardless. I would be interested to hear if @purcell has any input on this.
from s.el.
@purcell - Hi Steve, any thoughts?
from s.el.
Related to backwards compatibility / testing capability for the package to robustly support older Emacs versions. We have access to 24.x and up via Steve's purcell/[email protected]
.
There's a couple of caveats specific to GitHub actions as CI.
However on a local run the tests pass on 26.3 as illustrated below:
Potentially this can be mitigated using a different CI, or using Docker containers instead of the standard GH Action internal runners.
The other question...
Do we really need to support Emacs prior to 27.1? I have no data on usage of legacy versions. Does anyone?
from s.el.
FWIW we get one failing example on Emacs 24.1 (run locally.)
from s.el.
Resolved as dropping Emacs 23.x support.
from s.el.
Related Issues (20)
- Time for a new melpa-stable release? HOT 7
- Inclusion in Emacs HOT 12
- s-replace-all case-issue HOT 3
- Marmalade is dead, and the document should be updated correspondingly. HOT 1
- [feature request] function to split string into cons cell HOT 5
- Cosmetic change to `s-trim-right`
- Wildcard match? HOT 1
- Is it dead... HOT 10
- Functions which use `save-match-data` `with-temp-buffer` - side-effect-free? HOT 4
- (s-unindent s &optional bol-char) HOT 4
- 🐣 [REQUEST] - s-url-encode / s-url-decode HOT 10
- 🪲 [BUG] - Under CI 26.{1..3} fail due to no marker in buffer HOT 2
- 🪲 [BUG] - create-docs.sh failing HOT 2
- 🪲 [BUG] - Emacs 24.4 & 24.5 fail tests on CI. HOT 3
- 🐣 [REQUEST] - add s-truncate-width HOT 3
- Use ETD as a development dependency for example/tests/docs
- RFC : Dropping support for Emacs versions below 26. HOT 4
- 🐣 [REQUEST] - Add a way to check the style of given string HOT 1
- 🪲 [BUG] - s-split-words splits properly capitalized words like SPARCstation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s.el.