Giter Club home page Giter Club logo

Comments (2)

copyninja avatar copyninja commented on May 24, 2024

Yes this sounds reasonable. Most of the Rust packages uses features where there will be a default feature which is like these are sane defaults and there will be additional features which gives additional stuff. So from your explanation above it feels like core should be default feature and io-tokio is feature when user opts in for tokio dependency.

I'm not fully familiar with wormhole so not sure which should be default feature. i.e core or cli or both core and cli.

Just my 2 cents.

from magic-wormhole.rs.

warner avatar warner commented on May 24, 2024

Ok, based on your comments and those of some other rust folks, I'm gonna aim for this:

  • one crate, named magic-wormhole
  • cargo install magic-wormhole gets you bin/wormhole (Cargo.toml will have a [[bin]] name = "wormhole" with path = "src/bin/main.rs")
  • there are two features, named io-blocking and io-tokio, both on by default
  • apps probably want to add a dependency like magic-wormhole = { version = "0.1", default-features = false, features = ["io-tokio"] }
  • but if they forget, things will still work, they'll just get some spurious dependencies

I still want to see if cargo install magic-wormhole picks up the non-required IO layers, or if the required-features in our Cargo.toml is enough to avoid those.

from magic-wormhole.rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.