Comments (2)
Yes this sounds reasonable. Most of the Rust packages uses features where there will be a default feature which is like these are sane defaults and there will be additional features which gives additional stuff. So from your explanation above it feels like core should be default feature and io-tokio is feature when user opts in for tokio dependency.
I'm not fully familiar with wormhole so not sure which should be default feature. i.e core or cli or both core and cli.
Just my 2 cents.
from magic-wormhole.rs.
Ok, based on your comments and those of some other rust folks, I'm gonna aim for this:
- one crate, named
magic-wormhole
cargo install magic-wormhole
gets you bin/wormhole (Cargo.toml
will have a[[bin]] name = "wormhole"
withpath = "src/bin/main.rs"
)- there are two features, named
io-blocking
andio-tokio
, both on by default - apps probably want to add a dependency like
magic-wormhole = { version = "0.1", default-features = false, features = ["io-tokio"] }
- but if they forget, things will still work, they'll just get some spurious dependencies
I still want to see if cargo install magic-wormhole
picks up the non-required IO layers, or if the required-features
in our Cargo.toml
is enough to avoid those.
from magic-wormhole.rs.
Related Issues (20)
- Panic triggered when sending file to Wormhole William HOT 7
- Bad license badge in README.md HOT 1
- Add a man page HOT 1
- Generate shell completion
- Tab completion HOT 5
- Gather transit connection information programmatically HOT 4
- Sender hangs when the file size is a multiple of 4096 HOT 3
- Provide example code in source form HOT 6
- Add 32bit build on Windows HOT 4
- Allow compiling without clipboard support HOT 1
- transfer: receive wormhole close should not throw error when failed HOT 5
- transfer: program not exiting when sending an empty file HOT 15
- Panics when IPv6 is disabled HOT 5
- Cancellation doesn't work in all cases
- Detect broken TCP connection to peer HOT 1
- Port forwarding crashes HOT 4
- AddrNotAvailable error for IPv4 on Windows HOT 1
- RUSTSEC-2022-0048: xml-rs is Unmaintained HOT 1
- Using tcp relay with tcp:hostname syntax will panic
- Feature Request: cli installable using cargo-install HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magic-wormhole.rs.