Giter Club home page Giter Club logo

Comments (6)

tomreece avatar tomreece commented on August 14, 2024

Hi @norgeindian thank you for the report. However you're mentioning an action group that lives in the Magento2 repository, not in this MFTF repository. I would suggest moving your issue to https://github.com/magento/magento2

Thanks!

from magento2-functional-testing-framework.

norgeindian avatar norgeindian commented on August 14, 2024

Hi @tomreece,
that is exactly what I did a few days before I opened this issue (see magento/magento2#22879) where I was told to open it here...

Please be so kind and discuss internally who is responsible for that, so this gets solved.

Thanks !

from magento2-functional-testing-framework.

tomreece avatar tomreece commented on August 14, 2024

I investigated further and discovered that someone has created this action group:
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml#L345

ProductSetAdvancedTierFixedPricing

Can you make use of this?

from magento2-functional-testing-framework.

norgeindian avatar norgeindian commented on August 14, 2024

@tomreece, yes, this looks good. But then the original actionGroup should be renamed to ProductSetAdvancedTierDiscountPricing, so it gets obvious what this actionGroup actually does and the price argument should be removed. Shall I open a pull request in the Magento repository or what would be the correct way to go?

from magento2-functional-testing-framework.

tomreece avatar tomreece commented on August 14, 2024

@norgeindian

I don't want to discourage you from opening the pull request, but renaming an existing action group is considered a breaking change because some other extensions may depend on that action group to exist.

I don't expect this change to be possible and don't expect the PR to be approved.

@okolesnyk what do you think?

from magento2-functional-testing-framework.

jilu1 avatar jilu1 commented on August 14, 2024

@norgeindian
Now you can deprecated an action group if it's outdated using "deprecated" attribute. Close this issue.

from magento2-functional-testing-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.