Comments (6)
Hi @norgeindian thank you for the report. However you're mentioning an action group that lives in the Magento2 repository, not in this MFTF repository. I would suggest moving your issue to https://github.com/magento/magento2
Thanks!
from magento2-functional-testing-framework.
Hi @tomreece,
that is exactly what I did a few days before I opened this issue (see magento/magento2#22879) where I was told to open it here...
Please be so kind and discuss internally who is responsible for that, so this gets solved.
Thanks !
from magento2-functional-testing-framework.
I investigated further and discovered that someone has created this action group:
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml#L345
ProductSetAdvancedTierFixedPricing
Can you make use of this?
from magento2-functional-testing-framework.
@tomreece, yes, this looks good. But then the original actionGroup should be renamed to ProductSetAdvancedTierDiscountPricing, so it gets obvious what this actionGroup actually does and the price argument should be removed. Shall I open a pull request in the Magento repository or what would be the correct way to go?
from magento2-functional-testing-framework.
I don't want to discourage you from opening the pull request, but renaming an existing action group is considered a breaking change because some other extensions may depend on that action group to exist.
I don't expect this change to be possible and don't expect the PR to be approved.
@okolesnyk what do you think?
from magento2-functional-testing-framework.
@norgeindian
Now you can deprecated an action group if it's outdated using "deprecated" attribute. Close this issue.
from magento2-functional-testing-framework.
Related Issues (20)
- Can't install MFTF framework HOT 4
- Load URL with Basic Http Authentication in MFTF HOT 2
- Entity with a CreateDataKey of createSimpleProduct could not be found HOT 1
- Invalid argument supplied for foreach() at ../src/Magento/FunctionalTestingFramework/Extension/BrowserLogUtil HOT 1
- CLI command execution in MFTF throws error HOT 2
- How to add chrome browser desired capabilities for testing ? HOT 1
- Errors via allure dependency HOT 3
- upgrade:tests references nonexistent class HOT 2
- Entity with a CreateDataKey of createCustomer could not be found HOT 2
- Serialization of 'Closure' is not allowed HOT 1
- update symfony/http-foundation HOT 1
- run:test with --remove not creating testManifest.txt file HOT 3
- Filesystem::remove() argument #1 must be string, SplFileInfo given HOT 8
- v4.3.4 - Empty exception messages thrown after test failure HOT 2
- v4.3.4 - Action waitForElementClickable ignores the "time" argument HOT 1
- Upgrading Magento 2 functional testing framework above 4.2.1 breaks test because of Namespace Changes in allure-framework HOT 2
- cannot use strings with comma sign in locatorFunction as it is wrapped with " which breaks Php HOT 1
- Console command build:project starts subprocess with system-default PHP instead of the runtime PHP HOT 1
- symfony/console dependency mismatch in MFTF v4.7.2 Standalone and Magento v.2.4.7 HOT 1
- Helpers Autoload Issue - Class `Group\AppConfigDumpSuite` is not defined. Autoload it or include into '_bootstrap.php' file of 'tests' directory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2-functional-testing-framework.