Giter Club home page Giter Club logo

Comments (6)

KevinBKozan avatar KevinBKozan commented on August 11, 2024

@lbajsarowicz Thanks for reporting this! At some point in the past we were forced to update our codesniffer rulesets, and tried to match whatever was in the current develop branch (which may or may not have included the above irritating rule).

I am going to create a ticket internally to fix this, as I agree that our standards should allign with the main application..

from magento2-functional-testing-framework.

ihor-sviziev avatar ihor-sviziev commented on August 11, 2024

https://github.com/magento/marketplace-eqp - here is one more set of rules. Different rule set.

from magento2-functional-testing-framework.

ravmenon avatar ravmenon commented on August 11, 2024

@ihor-sviziev we do plan to consolidate the EQP rules with core M2 and possibly others - there is a plan in the works. Will share more more details once we finalize it.

from magento2-functional-testing-framework.

tomreece avatar tomreece commented on August 11, 2024

Internal ticket
https://jira.corp.magento.com/browse/MQE-1341

from magento2-functional-testing-framework.

lbajsarowicz avatar lbajsarowicz commented on August 11, 2024

@tomreece / @okolesnyk - Support for PHP 7.0 and 7.1 should be dropped.

from magento2-functional-testing-framework.

lbajsarowicz avatar lbajsarowicz commented on August 11, 2024

Magento codebase is too different from MFTF, so the full set of rules does not make sense.

We should follow most of the PHP rules from magento/magento2 repository, but drop the ones specific for Magento.

phpcs-failures.txt

from magento2-functional-testing-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.