Giter Club home page Giter Club logo

Comments (8)

Joly0 avatar Joly0 commented on May 28, 2024 1

Ah, that makes sense. Thanks for your explanation

from enhancr.

mafiosnik777 avatar mafiosnik777 commented on May 28, 2024

Quality is absolutely horrible because you used the default model and I assume its real-life content if its from a smartphone. Default model is animevideov3, which only works well for animated content.

https://upscale.wiki/wiki/Model_Database

Get a model thats actually trained on real-life content, you can load custom models when you press models button in the sidebar.

Why it gets flipped, I have absolutely no idea. I don't flip stuff in the code. @Joly0

from enhancr.

Joly0 avatar Joly0 commented on May 28, 2024

Hm, i see my fault with the models, but i didnt see anywhere, that the default is "animevideov3" and i need another one for real-life content, but thanks for the clarification, i have to test another model.
But just as a side-note, i did read the wiki before using enhancr, and even the settings page doesnt mention what model is the default https://github.com/mafiosnik777/enhancr/wiki/Tune-enhancr:-Settings, or am i missing something?

Hm, thats unfortunate (the issue with the flipped video). I could probably try to flip it by 90° with the ffmpeg settings, but i am not sure

from enhancr.

Joly0 avatar Joly0 commented on May 28, 2024

Btw, i have tried these 3 models
grafik
and the result quality is still not good at all. Following your link these are found under "Realistic Photos", so i assume, these should be correct models to use.

from enhancr.

mafiosnik777 avatar mafiosnik777 commented on May 28, 2024

Yeah, only reference to animevideov3 is in the benchmarks, could have highlighted that better.

(Real)ESRGAN isn't really good for real life stuff, you're better off just using Topaz Video AI for upscaling this type of footage.

UniScale is the only half decent model, but still "eh" in my opinion, maybe try that.

For the flipping stuff, changing it in ffmpeg probably won't have an effect because I append arguments to scale to the ffmpeg args, so people can use lower scales for 4x models etc.

Maybe the issue even lies in that because it calculates wrong, i'll look into it. @Joly0

from enhancr.

mafiosnik777 avatar mafiosnik777 commented on May 28, 2024

Closing due to inactivity.

from enhancr.

Joly0 avatar Joly0 commented on May 28, 2024

Did you look into it?

from enhancr.

mafiosnik777 avatar mafiosnik777 commented on May 28, 2024

Did you look into it?

Yep. Won't fix.

Most phones actually record at horizontal resolution with a vertical flip flag that is read by media players, according to the orientation of the phone when recording.

There are 3 main ways for those flip methods, some hard to check for some not. I have no plans currently to adjust for that behaviour, but now you know what causes it.

from enhancr.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.