Giter Club home page Giter Club logo

Comments (12)

mafintosh avatar mafintosh commented on August 12, 2024

The api seems to indicate that this was using tar-fs and not tar-stream right?

from tar-stream.

max-mapper avatar max-mapper commented on August 12, 2024

sorry, yea, wrong repo

its worth noting that this equivalent code doesnt run out of memory and completes, but takes longer than I think tar-stream would take if it wasnt leaking

var tar = require('tar')
var fstream = require('fstream')
var reader = fstream.Reader({type: "Directory", path: '/Users/max/Downloads/audiobooks/'})
var pack = tar.Pack()
reader.pipe(pack).pipe(tar.Extract({path: '/Users/max/Downloads/audiobooks2'}))

from tar-stream.

mafintosh avatar mafintosh commented on August 12, 2024

Which versions of tar-stream and tar-fs are you using? Also which version of node?

from tar-stream.

max-mapper avatar max-mapper commented on August 12, 2024

[email protected], [email protected], [email protected]

from tar-stream.

mafintosh avatar mafintosh commented on August 12, 2024

Using the latests versions I just copied a 3.7 gb directory using tar-fs in 7.5 seconds on my Macbook with no apparent leak. Using node-tar and the snippet you linked it still hasn't finished (been running for +5min now).
I'll try to see if I can reproduce the issue...

from tar-stream.

mafintosh avatar mafintosh commented on August 12, 2024

Do you have any symlinks in the folder you are trying to copy?

from tar-stream.

max-mapper avatar max-mapper commented on August 12, 2024

Hmmm, no symlinks. I first tried copying a 10gb folder full of mp3s, then a
sub folder of about 1gb of mp3s. Maybe it is related to the quantity of
files?

On Sunday, December 22, 2013, Mathias Buus wrote:

Do you have any symlinks in the folder you are trying to copy?


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-31097152
.

from tar-stream.

mafintosh avatar mafintosh commented on August 12, 2024

Did the folder contain a lot of sub folders?

from tar-stream.

max-mapper avatar max-mapper commented on August 12, 2024

one of the folders that crashes every time: 338 documents, 27 folders, 4,324,597,805 bytes (4.33 GB on disk)

from tar-stream.

mafintosh avatar mafintosh commented on August 12, 2024

I think I've found (and solved) the issue. It was due to a bug being triggered by a long filename (>100 characters) that caused it to explode. It should be fixed now. Could you try upgrading tar-fs to 0.1.2 and try again?

from tar-stream.

max-mapper avatar max-mapper commented on August 12, 2024

nice, copies 485 documents, 25 folders, 9,279,350,569 bytes (9.28 GB on disk) in 38423ms and 338 documents, 27 folders, 4,324,597,805 bytes (4.33 GB on disk) in 17659ms

from tar-stream.

mafintosh avatar mafintosh commented on August 12, 2024

Nice! How long does it take to do it with node-tar?

from tar-stream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.