Comments (5)
I tried solving this the other day I was fiddling with the repo to no avail. I might be able to have a look again soon-ish if you don't beat me to it.
from gulp-sri-hash.
Two issues prevented tests to pass on Windows:
-
Tests for relative path resolution were not portable and checked path separators by forward-slash (but Windows uses backward slashes). Commit ead6130 fixes this issue.
-
Hash checksum calculation yields different results if files in question use
CRLF
line endings. Therefore checksums didn't match and tests failed. Commit 7ec45d8 forces checking out css- and js-files withLF
file endings.
@XhmikosR Can you pull the latest changes from master
, and run tests again? You may have to manually convert line-endings (or do a fresh new checkout). This time it should work, though 😄
Also, I updated the README.md
with a note about this line-ending issue (6620fa4).
from gulp-sri-hash.
@macedigital: Looks good to me. A couple of thoughts:
- I would remove the
init
section from AppVeyor; you shouldn't rely on such things - An alternative approach to .gitattributes would be to make sure you just do
foo.replace(/\r\n/g, '\n');
from gulp-sri-hash.
Oh, an irrelevant thing, but I don't want to make a new issue.
Make sure you use the files
section in package.json so that you don't include unneeded files when publishing. Like:
"files": [
"index.js"
]
from gulp-sri-hash.
@XhmikosR Thanks for your help! And don't hesitate to open tickets ;)
Regarding your feedback:
I removed the init
section from the appveyor.yml
, it's definitively not needed.
Line-ending settings in .gitattributes
are local to this module, and in a sense, only affect the test fixtures. In practice, it shouldn't actually matter with which line endings files are saved with, as long they are never converted.
Also, I'll consider limiting the number of files for the next release (e.g. excluding test files).
from gulp-sri-hash.
Related Issues (15)
- Tests on path resolution fail HOT 5
- Add `crossorigin="anonymous"` HOT 1
- Ignore cache busting hash in URL HOT 3
- Version 10 of node.js has been released HOT 1
- Changes my HTML tags and rewrites them HOT 3
- Gulp dependency HOT 8
- Paths for scripts should use `path.posix` HOT 5
- `doctype` becomes uppercase after using gulp-sri-hash HOT 3
- gulp-sri-hash (unnecessarily) escapes unicode characters HOT 2
- An in-range update of eslint is breaking the build 🚨 HOT 2
- Hash external resources HOT 3
- gulp-sri-hash with gulp-sourcemaps
- An in-range update of eslint-config-airbnb-base is breaking the build 🚨 HOT 1
- Wrong sha512 calculation(?) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-sri-hash.