Comments (6)
Hi @lmiq, great to hear that it's fixed.
I'm using CellListMap for contact detection in a DEM code I'm developing for granular materials simulations. I have a lot of sample simulations and was re-running all of them, and the error just appeared. That's how I found the pathological coordinates. My simulations usually run inside a big box, some have only 1 or 2 particles, and some have a lot of particles and are very crowded.
I updated the package and re-ran all my simulations, and everything appears to be working fine.
Again, thank you very much for all your work. Your package is great.
Best regards.
from celllistmap.jl.
Thanks for reporting. I'll fix that asap.
from celllistmap.jl.
It is fixed in version 0.8.13 to appear in the registry as soon as it is merged. Sorry for that, version 0.8.12 was a significant rewrite of the package and that slipped off. I've added now additional unit tests to avoid that regression again.
from celllistmap.jl.
Thank you for your quick fix, although I regret to say that the problem still persists. For example this code:
r = [[7,10,10], [18,10,10]]
system = InPlaceNeighborList(x=r, cutoff=3.0, parallel=false)
list = neighborlist!(system)
r = [[10.89658911843461, 3.709237933444153, 10.0], [13.894156281793144, 11.054172259416013, 10.0]]
update!(system, r)
will produce the same error.
Im using the 0.8.13 version. As a reference, the 0.8.10 version worked fine with this same code.
Quick edit: It may be helpful to allow the user to define the expected bounds of the simulation for nonperiodic systems to avoid these unexpected errors?
Best regards.
from celllistmap.jl.
The fix there is easy. I'm curious however on how are you arriving to these situations. I have quite an extensive test test of pathological coordinates, and none of my tests were failing. Maybe that can be useful for adding additional tests here. (The issue is related to testing "greater or equal" conditions in the limit of the numerical accuracy of floating point operations. Now I added a safer boundary way larger than that accuracy for the dimensions where the problem were occurring).
I will release version 0.8.14 with the new fix as soon as the CI tests pass. If you want you can check it by using the release-0.8.14
dev branch.
from celllistmap.jl.
Fixed in 0.8.14 - released now in the registry.
Please let me (always) know if you experience this or any other issue.
from celllistmap.jl.
Related Issues (20)
- simplify output conversion for numpy arrays
- dealing with highly non-homogeneous systems HOT 6
- Error when creating PeriodicSystem with empty positions HOT 1
- Suggestion: Is it possible to output the coordinates and size of cells so one can visualize them? HOT 2
- Suggestion: In a transient simulation, based on the first time step, can I define a "box of interest"? HOT 2
- Does the 'update_lists = false' option only apply to periodic systems? HOT 5
- Is it possible to store some historical information of pairs? HOT 26
- Neighborlists contain repeated elements HOT 4
- Make the high-level interface more flexible HOT 3
- InPlaceNeighborList() result is incorrect HOT 10
- Setting `nbatches` doesn't work HOT 1
- `limits(x, y)` requires arrays of the same type for no reason HOT 1
- Update previous cells instead of re-initializing all cells HOT 11
- CellListMap hangs HOT 9
- ReverseDiff gradients HOT 14
- CellListMap allocating too much memory HOT 13
- Difference from brute force HOT 6
- Computing virial and pressure HOT 6
- Removing periodic boundary conditions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from celllistmap.jl.