Giter Club home page Giter Club logo

Comments (4)

TaylerUva avatar TaylerUva commented on May 26, 2024 1

For my use case a config would be better. As long as that will work with logging from other classes.

i.e. I'm a log! will get logged when do_thing() is called in TaskOnKart.run

from logging import getLogger


class MyClass:
    logger = getLogger(__name__)
    def do_thing():
        self.logger.info("I'm a log!")

Doing it through a config will also make your existing documentation more true. (I had to look at source code to realize the logging config was ignored by build)

from gokart.

vaaaaanquish avatar vaaaaanquish commented on May 26, 2024 1

I was reading luigi. It looks like putting the logger configuration to luigi.build args.

from gokart.

vaaaaanquish avatar vaaaaanquish commented on May 26, 2024

@TaylerUva [ASK]
There is a way to make a config, what do you think of it?
example: https://gist.github.com/vaaaaanquish/8719a3470aa83c7985c5416ece0299c0

Or do you think gokart.build argument would be better?

from gokart.

vaaaaanquish avatar vaaaaanquish commented on May 26, 2024

Doing it through a config will also make your existing documentation more true. (I had to look at source code to realize the logging config was ignored by build)

That's right. I think so too, that's very confusing.

from gokart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.