Giter Club home page Giter Club logo

Comments (7)

damaestro avatar damaestro commented on June 2, 2024 1

Ah, and I did have to enable G+. Sorry if that was not clear.

from confidant.

ryan-lane avatar ryan-lane commented on June 2, 2024

This is related to some info @damaestro added in the IRC channel. It's necessary to enable the people API for google auth to work, but that's not documented, along with most of the rest of that setup.

from confidant.

ambrons avatar ambrons commented on June 2, 2024

So I'm running into the same issue that Jon was having with authentication. I have the Google People API enabled for project / oauth2 client configuration.

While I'm working through figuring out what's going on I found this Google Site:
https://developers.google.com/+/web/api/rest/oauth#authorization-scopes

Which states the scopes you have configured are deprecated.

from confidant.

ryan-lane avatar ryan-lane commented on June 2, 2024

They are indeed deprecated. In the 1.1 branch we're using the updated scopes:

https://github.com/lyft/confidant/blob/1.1/confidant/authnz/userauth.py#L274-L285

That said, the deprecated scopes do work. What issue are you running into?

from confidant.

ambrons avatar ambrons commented on June 2, 2024

@ryan-lane I was having an issue getting the google suffix working. It was throwing a 500 error with "NoneType" attribute when checking against the email address:
AttributeError: 'NoneType' object has no attribute 'endswith'

I added the Google People API to my Google Project and it wasn't fetching. So I searched all the google APIs for userinfo usage. I switched to the Google+ API and it's now working.

As for the deprecated apis yeah Google says they will support them for a while. Just an FYI, good to see it's updated.

from confidant.

pnathan avatar pnathan commented on June 2, 2024

Just as an annotation: G+ does have to be enabled.

Note that the exception should ideally be trapped and the error message from google emitted. Something like checking for user.email being None and using logging.error with result.user.data would suffice, internal research shows.

from confidant.

ryan-lane avatar ryan-lane commented on June 2, 2024

Added some basic google auth docs: #84

from confidant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.