Giter Club home page Giter Club logo

Comments (4)

axelson avatar axelson commented on July 29, 2024

My PR includes basic instructions for this: #61

from swipe.

loup-brun avatar loup-brun commented on July 29, 2024

Hmm... Dynamic content can be achieved by first destroying the existing Swipe instance and then creating a new one after dynamically playing with the content of the slider.

Basically,

window.mySwipe1 = new Swipe(elem, options);
mySwipe1.kill();
/* dynamically add slides HERE */
window.mySwipe2 = new Swipe(elem, options});

// repeat this cycle every time slides are added, ideally erasing each Swipe instance after `kill()`

I acknowledge, this creates a lot of overhead.

@axelson In your PR, you're making an exception for the setup behavior only for the startSlide option. I would suggest making it possible to pass an (optional) options parameter to the setup() method, which could override the initial configuration (passed when creating a Swipe instance). This could be very helpful, since it could be desirable to alter some options over time without having to create a new Swipe instance every time.

I think extending (generalizing) this way of altering the configuration to all options is a better design approach (rather than relying on exceptions). Please feel free to share your thoughts! 😄

from swipe.

axelson avatar axelson commented on July 29, 2024

Yeah I think that makes sense, just wasn't sure how much work it would be to set all the options again. But perhaps if we extracted it to a new method, something like configureOptions then that could be used both in the setup case as well as the new case.

from swipe.

loup-brun avatar loup-brun commented on July 29, 2024

Yes, this configureOptions could be abstracted to a private (internal) method. However, I'm afraid such a design change will be a good deal of work considering the way Swipe is already built: the configuration options seem to be pretty much spread out accross the different parts of Swipe. I'll have to look into the code and see if it is actually possible to do this in Swipe!

from swipe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.