Giter Club home page Giter Club logo

Comments (7)

maxfahl avatar maxfahl commented on July 29, 2024 2

This is a bit out of topic. But do you guys know of any wrapper for this slider in Angular 4?

from swipe.

lyfeyaj avatar lyfeyaj commented on July 29, 2024

Great feature! Merged!

from swipe.

lyfeyaj avatar lyfeyaj commented on July 29, 2024

Hi @loup-brun , do you mind if I add you as collaborator?

from swipe.

loup-brun avatar loup-brun commented on July 29, 2024

Sure - no problem ;) Happy to help!

from swipe.

loup-brun avatar loup-brun commented on July 29, 2024

Let me know if the multiple directives sound confusing. Maybe there could be a better design, but in respect to the Angular scopes, I think this is a relatively robust architecture.

from swipe.

lyfeyaj avatar lyfeyaj commented on July 29, 2024

Using multiple directives is ok to me.

Below is how I use swipe in my angular project for several months ago:

'use strict'

###*
 # @ngdoc directive
 # @name vetServicesApp.directive:common/swipe
 # @description
 # # common/swipe
###
angular.module('vetServicesApp.directives')
  .directive('swipe', [
    '$timeout'
    ($timeout) ->
      restrict: 'AE'
      link: (scope, element, attrs) ->
        initSwipe = () ->
          if scope.mySwipe
            scope.mySwipe.kill()
            scope.mySwipe = null
          scope.mySwipe = new Swipe(element[0],
            startSlide: 0
            speed: 400
            auto: parseInt(attrs.auto)
            draggable: true
            autoRestart: false
            continuous: true
            disableScroll: false
            stopPropagation: false
            callback: (index, elem) ->
              angular.element(".swipe-num li")
                     .removeClass("active")
                     .eq(index)
                     .addClass("active")
              return
            transitionEnd: (index, elem) ->
              return
          )
          return

        if attrs.usingNgRepeat
          scope.$on 'Event:ng-repeat-finish-render', ->
            $timeout(initSwipe, 100)
        else
          $timeout(initSwipe, 100)

        scope.$on 'Event:ImagesLoaded', ->
          $timeout ->
            scope.mySwipe.setup()
          , 100
        return
])

There are two things may cause problems when using swipe in angular:

  1. When using with ng-repeat, due to the async process of ng-repeat, swipe may init before the items are loaded, especially when loading items via Ajax.
  2. Another common problem is when using swipe with images. There are occasions that swipe will not perform properly when images are loading with high latency.

So, you can see that I use two additional directives for monitoring ng-repeat and image loading status to initiate or setup swipe.

It is great If these two problems can be fixed with better solutions ^_^
@loup-brun Any good ideas?

from swipe.

loup-brun avatar loup-brun commented on July 29, 2024

I'll have to make some tests with ng-repeat, since I haven't used Swipe with that directive - though I can see how pertinent it can be.

Since wrapping the Swipe library in Angular brings some compromises, we might (just a quick thought, not yet a serious consideration) port the project to a different repository to better enable Angular support.

from swipe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.