Giter Club home page Giter Club logo

Comments (3)

lydell avatar lydell commented on May 29, 2024

Hi! These are the worries I have about this feature: #41 (comment)

Thoughts?

from eslint-plugin-simple-import-sort.

mtroskot avatar mtroskot commented on May 29, 2024

In my opinion it's easier to find the import that I'm looking for by reading the comment of the group, than reading every single import.
Also to me line breaks after every import group don't add any readability without comments.

import React, { useCallback, useState } from 'react';
import { View } from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context';
import { connect } from 'react-redux';

import { CustomButton } from 'src/components';

import CurrentTimezoneClock from 'src/screens/Clock/CurrentTimezoneClock';
import TimezoneEntries from 'src/screens/Clock/TimezoneEntries';

import { StoreState } from 'src/store/rootReducer';
import { fetchTimezoneEntries } from 'src/store/timezone/timezoneActions';
import { timezoneEntriesSelector } from 'src/store/timezone/timezoneSelectors';
import { checkIfErrorSelector, checkIfLoadingSelector, checkIfRefreshingSelector } from 'src/store/ui/uiSelectors';

import { NavigationService } from 'src/services';

import { DateUtils, HooksUtils } from 'src/utils';
import { clockFormat, dateFormat } from 'src/utils/DateUtils';

import { eIcons } from 'src/types/enums';
import { iSavedTimezoneEntry } from 'src/types/interfaces';
import { eScreenNames } from 'src/types/navigation';
import { TimezoneActionTypes } from 'src/types/store/actionTypes';

import styles from 'src/screens/Clock/styles';
import { appStyles, dimensions } from 'src/styles';
...

These comments should be optional, that's why all #41 comment concers, would be taken on own responsibility, if they are hard to implement.

from eslint-plugin-simple-import-sort.

lydell avatar lydell commented on May 29, 2024

I’ve decided that this plugin won’t be adding comments.

I understand that some might want them, but supporting the feature is way too complicated for a plugin with the word “simple” in its name.

from eslint-plugin-simple-import-sort.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.