Comments (3)
Hi! These are the worries I have about this feature: #41 (comment)
Thoughts?
from eslint-plugin-simple-import-sort.
In my opinion it's easier to find the import that I'm looking for by reading the comment of the group, than reading every single import.
Also to me line breaks after every import group don't add any readability without comments.
import React, { useCallback, useState } from 'react';
import { View } from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context';
import { connect } from 'react-redux';
import { CustomButton } from 'src/components';
import CurrentTimezoneClock from 'src/screens/Clock/CurrentTimezoneClock';
import TimezoneEntries from 'src/screens/Clock/TimezoneEntries';
import { StoreState } from 'src/store/rootReducer';
import { fetchTimezoneEntries } from 'src/store/timezone/timezoneActions';
import { timezoneEntriesSelector } from 'src/store/timezone/timezoneSelectors';
import { checkIfErrorSelector, checkIfLoadingSelector, checkIfRefreshingSelector } from 'src/store/ui/uiSelectors';
import { NavigationService } from 'src/services';
import { DateUtils, HooksUtils } from 'src/utils';
import { clockFormat, dateFormat } from 'src/utils/DateUtils';
import { eIcons } from 'src/types/enums';
import { iSavedTimezoneEntry } from 'src/types/interfaces';
import { eScreenNames } from 'src/types/navigation';
import { TimezoneActionTypes } from 'src/types/store/actionTypes';
import styles from 'src/screens/Clock/styles';
import { appStyles, dimensions } from 'src/styles';
...
These comments should be optional, that's why all #41 comment concers, would be taken on own responsibility, if they are hard to implement.
from eslint-plugin-simple-import-sort.
I’ve decided that this plugin won’t be adding comments.
I understand that some might want them, but supporting the feature is way too complicated for a plugin with the word “simple” in its name.
from eslint-plugin-simple-import-sort.
Related Issues (20)
- Question: how to approach the workaround for padding-line-between-statements? HOT 2
- Please update your docs HOT 2
- Named imports with `as` aren't sure where to go HOT 2
- Using without new lines between groups HOT 2
- Error with aliased imports and eslint-plugin-import HOT 1
- Support for namespace imports HOT 8
- Prepare for ESLint 9: Deprecated methods
- sorted import specifiers missing space HOT 2
- how to make side effect always be top HOT 2
- I thought library imports were supposed to come before relative imports? HOT 4
- Error: Run autofix to sort these imports! HOT 7
- Duplicate imports are not being removed HOT 1
- Conflict between eslint-plugin-simple-import-sort and esbenp.prettier-vscode HOT 2
- TypeError: parentNode.body is not iterable in v11 HOT 6
- Import in group despite not being matched by regex expression HOT 2
- What is the difference vs eslint-plugin-import HOT 1
- Add TypeScript types HOT 7
- Explore configuration with real regex instead of strings HOT 1
- Why add empty line bettween two react imports HOT 3
- Option to prevent sorting inside a group HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-simple-import-sort.