bug: import { ,ofSubject } from 'rxjs'; about eslint-plugin-simple-import-sort HOT 13 CLOSED

Upgrade to @typescript-eslint/parser 2.18.0 and your problem should be gone!

from eslint-plugin-simple-import-sort.

Change plugin:@typescript-eslint/recommended into plugin:@typescript-eslint/base to make it even more minimal ;)

from eslint-plugin-simple-import-sort.

@lydell I realized it was likely a similar parser issue but with a related plugin: turning off import/no-duplicates resolved the issue and resulted in the output you pasted above.

from eslint-plugin-simple-import-sort.

This is due to a bug in @typescript-eslint/parser. PR to fix it here: typescript-eslint/typescript-eslint#1487

Once that’s merged and released, you should be able to update @typescript-eslint/parser to fix the problem, and I’ll add a test for it and close this issue.

from eslint-plugin-simple-import-sort.

Hi!

When I tried to reproduce your issue, I got this:

import { of,Subject } from 'rxjs';

There must be something different in your environment.

from eslint-plugin-simple-import-sort.

Thanks for the fast reply.

That's interesting.

Using this eslint config:

{
  "parser": "@typescript-eslint/parser",
  "plugins": ["@typescript-eslint", "simple-import-sort", "prettier"],
  "extends": ["plugin:prettier/recommended", "plugin:@typescript-eslint/recommended"],
  "rules": {
    "simple-import-sort/sort": "error",
    "prettier/prettier": "error"
  }
}

from eslint-plugin-simple-import-sort.

This seems to only happen when using the TypeScript parser.

This test case fails: https://github.com/lydell/eslint-plugin-simple-import-sort/compare/typescript-issue

from eslint-plugin-simple-import-sort.

I reduced it to this minimal typescript eslint config to reproduce it:

{
  "plugins": ["@typescript-eslint", "simple-import-sort"],
  "extends": ["plugin:@typescript-eslint/recommended"],
  "rules": {
    "simple-import-sort/sort": "error"
  }
}

from eslint-plugin-simple-import-sort.

Just tested it with the even more minimal config (plugin:@typescript-eslint/base).

Still got the issue ...

Output:

import { ,ofSubject } from 'rxjs';

{
  "plugins": ["@typescript-eslint", "simple-import-sort"],
  "extends": ["plugin:@typescript-eslint/base"],
  "rules": {
    "simple-import-sort/sort": "error"
  }
}

from eslint-plugin-simple-import-sort.

Yes, that’s what I meant.

from eslint-plugin-simple-import-sort.

Also using the typescript parser and ending up with imports like this:

import { attr, belongsTo,hasMany } from Model from '@ember-data/model';

starting from:

import Model from '@ember-data/model';
import { attr, hasMany, belongsTo } from '@ember-data/model';

from eslint-plugin-simple-import-sort.

@runspired I get this output:

import Model from '@ember-data/model';
import { attr, belongsTo,hasMany } from '@ember-data/model';

There must be something different in your environment.

from eslint-plugin-simple-import-sort.

Issue is resolved. Thanks for the great work!

from eslint-plugin-simple-import-sort.