Add support for Generator and AsyncGenerator about seroval HOT 5 OPEN

Hi @lxsmnsyc I see this already implemented in code but is that not flagged ready to use?

Try to use it with solid start but seem like doesn't work

export const logHello = async function (message: string) {
  'use server'
  console.log(message)

  return {
    title: 'Hello World',
    async* [Symbol.asyncIterator](): AsyncIterator<number> {
      await Promise.resolve()
      yield 1
      await new Promise((resolve) => setTimeout(resolve, 1000))
      yield 2
      await new Promise((resolve) => setTimeout(resolve, 5000))
      yield 3
    },
  }
}

export const logHello = async function * (message: string) {
  "use server";
  console.log(message);

  yield { a: true }
  await new Promise((resolve) => setTimeout(resolve, 5000))

  yield { b: true }
};

from seroval.

@ducan-ne Last time I've tested this this should work. Please provide more info.

from seroval.

@lxsmnsyc
The lastest version should show catch the error
https://github.com/ducan-ne/solid-async-generator-reproduction/blob/main/src/actions.tsx
https://github.com/ducan-ne/solid-async-generator-reproduction/blob/main/src/components/Counter.tsx

for await (const value of logHello('Hello')) { not work either

Error

Uncaught (in promise) TypeError: logHello(...) is not a function or its return value is not async iterable

Or

Counter.tsx:20  Uncaught (in promise) {a: true}

This is my first time tried solid start so I'm not sure it's right way to use generator, but that's how we use it js

from seroval.

Okay I've tested this one, this isn't a Seroval problem. Please create an issue in SolidStart.

I intend to clean up this thread since it merits its own issue thread.

from seroval.

Okay, thank for your infromation

from seroval.