Comments (20)
If you would like, we can wait until the stable builds bootstrap themselves in my CI (I just enabled them today) to see if this is a 0.14.1 bug. If not, I'm willing to Git bisect what caused the issue, and fix it if I can.
But again, it's not just my decision on whether or not we continue to support this.
from libfm-qt.
from libfm-qt.
@agaida Please change QT_MINIMUM_VERSION to a suitable version -- I can't, always having the latest stable Qt.
from libfm-qt.
5.9? no - no chance.
Edit: Might sound harder than it is meant. We never promised portability to ancient versions of Qt or whole systems. As we introduced the minimum versions we had a look what we really use and take the lowest possible minimum. Thats all - so if we now use things from versions higher than our current minimum we had of course to change this.
from libfm-qt.
@tsujan - so i guess 5.10 is fine, should have a look at the log first
from libfm-qt.
I took a look at the latest stable Qt doc and found no mention of a version. Hopefully, you'll find something in your logs.
from libfm-qt.
hmm - it is not a bug with the Qt minimum version, it seems to be a bug with our latest build tool changes - i'm not into this that much, but i guess that @luis-pereira and @palinek could know more about.
If i'm right than we might add some lines in the projects where such things happend or revert some changes.
Third option: We just don't care - that would be unfair with so called LTS (Ubuntu LTS, Cent etc)
from libfm-qt.
I think this can be avoided by using QString(parent_str.get())
and, perhaps, similar things but:
(1) I can't test it (having Qt 5.12); and
(2) I can't be continuously cautious about whether this or that line of code isn't supported by an outdated version of Qt. The most I can do is checking the versions Qt doc sometimes adds to its explanations.
from libfm-qt.
Another point - if this is really introuced by our last merges - upps: in that case 0.14.1 is the last known release that works with these distributions and Qt versions and we really had to bump our minimum dependencies.
from libfm-qt.
an outdated version of Qt
This version of Qt is still supported in upstream Qt as an LTS release. If LXQt no longer wants to support it, that's fine, but please adjust QT_MINIMUM_VERSION
accordingly.
from libfm-qt.
@tsimonq2 You're the one seeing FTBFS. Could you please test my above-mentioned suggestion? If so, you might need to make more changes like that until FTBFS disappears. And if it doesn't disappear so easily, we'll know that we couldn't support that version of Qt.
from libfm-qt.
to see if this is a 0.14.1 bug
It definitely isn't.
EDIT: I mean, not in libfm-qt.
from libfm-qt.
Can do, @tsujan.
(It'll likely end up being next weekend; the 19.04 release is on Thursday and I need to spend most of my cycles on that.)
from libfm-qt.
@tsimonq2 - i don't know if you used the now changed build tools - a fast test would be to use the last released build tools with the current code.
from libfm-qt.
@agaida Did you have the latest lxqt-build-tools before compiling libfm-qt? I ask because I may not have.
from libfm-qt.
the released one from the repos - there was only three commits right now after the release
from libfm-qt.
the released one from the repos - there was only three commits right now after the release
Yes, I saw that.
from libfm-qt.
I've been building with 5.9 in one of machines.
I can try tomorrow if the issue is still not fixed.
from libfm-qt.
@luis-pereira Good! If it can't be compiled with 5.9, please make the necessary changes -- there should be only a few.
from libfm-qt.
I'll kick off a CI build right now to confirm. Thank you!
from libfm-qt.
Related Issues (20)
- libfm-qt6: Emptying Trash (in LXQt file dialog) causes a crash HOT 3
- Extra CPU time taken by folders containing many desktop entries HOT 4
- Thumbnails 4mb is the default in file dialog. HOT 8
- Saving a file without its file extension takes the default literally HOT 2
- Treat desktop entry icons like thumbnails HOT 1
- Enter key for SaveAs sometimes does not enter directory. HOT 2
- WARNING: Please do not silence compilation warnings of Qt5-based libfm-qt
- Crash in `PathBar::closeEditor` HOT 1
- allow using any terminal emulator specified by programs instead of only from a list file HOT 3
- Renaming a file upon completion causes the previous file to be selected HOT 3
- lxqt-menu-data is not specified as a build dependency of libfm-qt in the README file
- Update `archivers.list` and `lxqt-archiver` after recent changes in some MIME type strings HOT 6
- Add "Downloads" to places menu HOT 1
- Enable custom_args in terminal.cpp
- Rmdir installation error on Qt6 HOT 7
- Allowing pasting of full path into "File name" entry? HOT 4
- libfm-qt still requires gtk2 HOT 3
- Side Pane font does not change on-the-fly anymore (regression?) HOT 33
- File Properties windows open behind and stay behind File Dialog HOT 11
- [Feature request] PeaZip archiver integration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libfm-qt.