Giter Club home page Giter Club logo

Comments (18)

luis-pereira avatar luis-pereira commented on August 21, 2024

@kuh3h3
Try it in a build dir:

cd build
cmake <path to sources> -DCMAKE_INSTALL_PREFIX=/usr
make
make install

from libfm-qt.

kuh3h3 avatar kuh3h3 commented on August 21, 2024

@luis-pereira Thanks. fixed now

from libfm-qt.

tsujan avatar tsujan commented on August 21, 2024

I think this is a serious problem and should be fixed. The user has right to issue the first command but, in that case, he'll encounter an enormous amount of nested folders.

from libfm-qt.

tsujan avatar tsujan commented on August 21, 2024

@luis-pereira?

from libfm-qt.

agaida avatar agaida commented on August 21, 2024

sorry, why it is a problem - the only problem is that the to has no clue and that he will mess up his system - both are not upstream problems.
@kuh3h3 - please do yourself a favour and use the ubuntu/debian packaging tools, might be a little learning curve but it is worth it.

from libfm-qt.

tsujan avatar tsujan commented on August 21, 2024

@agaida I meant it as a general problem, not kuh3h3's -- he succeeded in compiling libfm-qt.

Why is it a problem? Because something as simple as cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr creates practically infinite nested folders. That isn't the case with pcmanfm-qt, for example. Of course, none of us does that but it's possible. IMO, telling the user he shouldn't issue a simple command similar to that is like telling him not to use a program in a way it might crash.

from libfm-qt.

luis-pereira avatar luis-pereira commented on August 21, 2024

@tsujan We don't support in source builds
Altough all documentation uses out of source build we don't enforce it.

from libfm-qt.

agaida avatar agaida commented on August 21, 2024

Right - maybe we should. @tsujan and i guess the very most packaging tools in distributions do this by default.

from libfm-qt.

luis-pereira avatar luis-pereira commented on August 21, 2024

@tsujan This issue will most certainly happen with all our librarys. But not with applications.
My proposal were is to enforce out of source builds. They are the standard.

from libfm-qt.

tsujan avatar tsujan commented on August 21, 2024

We don't support in source builds

If so, we should have made it impossible, not leaving it to create infinite nested folders. That's like I say I don't support a kind of usage for my app and if the user chooses it, any crash will be his/her responsibility!!

Somethings is definitely wrong here.

from libfm-qt.

agaida avatar agaida commented on August 21, 2024

We don't talk about simple users - we talk about users that have a dev background. At least they should have. To be crystal clear about: For the very most distributions cmake $foo .; make; make install it a precise shot into both feets. Thats why my answer. And the distribution support will also say: Wait a minute, why this should be our problem - thats not our supported way to do things. But we should give a hint about the need of out of tree compiling and then stop processing.

from libfm-qt.

tsujan avatar tsujan commented on August 21, 2024

@agaida My opinion is as simple as this and, although I'm a fallible human being, I try to act accordingly everywhere: Any well-structured system should make heavy mistakes impossible -- be it a computer program or a Weltanschauung.

from libfm-qt.

luis-pereira avatar luis-pereira commented on August 21, 2024

Yes, it should be enforced. But IMO it's not a big deal.
Experienced users will do out of source builds without thinking about it or actually read the documentation.
Newbies should and probably will follow the documentation and have no trouble.

I will write a module to enforce it ASAP.

from libfm-qt.

tsujan avatar tsujan commented on August 21, 2024

I will write a module to enforce it ASAP.

Thanks! Looking forward to it.

from libfm-qt.

agaida avatar agaida commented on August 21, 2024

Experienced users will do out of source builds without thinking about it or actually read the documentation.

Hihi - right, never ever spend a thought. And i was surprised that it is possible ...

from libfm-qt.

luis-pereira avatar luis-pereira commented on August 21, 2024

Fix proposal:
lxqt/lxqt-build-tools#28
lxqt/liblxqt#136
....

from libfm-qt.

agaida avatar agaida commented on August 21, 2024

Let's do it.

from libfm-qt.

agaida avatar agaida commented on August 21, 2024

Can be closed now - we allow only out of source builds

from libfm-qt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.