Comments (18)
@kuh3h3
Try it in a build dir:
cd build
cmake <path to sources> -DCMAKE_INSTALL_PREFIX=/usr
make
make install
from libfm-qt.
@luis-pereira Thanks. fixed now
from libfm-qt.
I think this is a serious problem and should be fixed. The user has right to issue the first command but, in that case, he'll encounter an enormous amount of nested folders.
from libfm-qt.
from libfm-qt.
sorry, why it is a problem - the only problem is that the to has no clue and that he will mess up his system - both are not upstream problems.
@kuh3h3 - please do yourself a favour and use the ubuntu/debian packaging tools, might be a little learning curve but it is worth it.
from libfm-qt.
@agaida I meant it as a general problem, not kuh3h3's -- he succeeded in compiling libfm-qt.
Why is it a problem? Because something as simple as cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr
creates practically infinite nested folders. That isn't the case with pcmanfm-qt, for example. Of course, none of us does that but it's possible. IMO, telling the user he shouldn't issue a simple command similar to that is like telling him not to use a program in a way it might crash.
from libfm-qt.
@tsujan We don't support in source builds
Altough all documentation uses out of source build we don't enforce it.
from libfm-qt.
Right - maybe we should. @tsujan and i guess the very most packaging tools in distributions do this by default.
from libfm-qt.
@tsujan This issue will most certainly happen with all our librarys. But not with applications.
My proposal were is to enforce out of source builds. They are the standard.
from libfm-qt.
We don't support in source builds
If so, we should have made it impossible, not leaving it to create infinite nested folders. That's like I say I don't support a kind of usage for my app and if the user chooses it, any crash will be his/her responsibility!!
Somethings is definitely wrong here.
from libfm-qt.
We don't talk about simple users - we talk about users that have a dev background. At least they should have. To be crystal clear about: For the very most distributions cmake $foo .; make; make install it a precise shot into both feets. Thats why my answer. And the distribution support will also say: Wait a minute, why this should be our problem - thats not our supported way to do things. But we should give a hint about the need of out of tree compiling and then stop processing.
from libfm-qt.
@agaida My opinion is as simple as this and, although I'm a fallible human being, I try to act accordingly everywhere: Any well-structured system should make heavy mistakes impossible -- be it a computer program or a Weltanschauung.
from libfm-qt.
Yes, it should be enforced. But IMO it's not a big deal.
Experienced users will do out of source builds without thinking about it or actually read the documentation.
Newbies should and probably will follow the documentation and have no trouble.
I will write a module to enforce it ASAP.
from libfm-qt.
I will write a module to enforce it ASAP.
Thanks! Looking forward to it.
from libfm-qt.
Experienced users will do out of source builds without thinking about it or actually read the documentation.
Hihi - right, never ever spend a thought. And i was surprised that it is possible ...
from libfm-qt.
Fix proposal:
lxqt/lxqt-build-tools#28
lxqt/liblxqt#136
....
from libfm-qt.
Let's do it.
from libfm-qt.
Can be closed now - we allow only out of source builds
from libfm-qt.
Related Issues (20)
- Opening trashed files
- Qt6: Path-bar's wheel scrolling doesn't work with cursor on path buttons HOT 1
- Deselection issue in file dialog HOT 1
- Wayland: crash when dropping items into the side-pane HOT 3
- CMake configure fails to check for qpa/qplatformdialoghelper. HOT 6
- Crash on dropping files from another app under Wayland
- DND menu is unresponsive to mouseover under Wayland
- libfm-qt6: Emptying Trash (in LXQt file dialog) causes a crash HOT 3
- Extra CPU time taken by folders containing many desktop entries HOT 4
- Thumbnails 4mb is the default in file dialog. HOT 8
- Saving a file without its file extension takes the default literally HOT 2
- Treat desktop entry icons like thumbnails HOT 1
- Enter key for SaveAs sometimes does not enter directory. HOT 2
- WARNING: Please do not silence compilation warnings of Qt5-based libfm-qt
- Crash in `PathBar::closeEditor` HOT 1
- allow using any terminal emulator specified by programs instead of only from a list file HOT 3
- Renaming a file upon completion causes the previous file to be selected HOT 3
- lxqt-menu-data is not specified as a build dependency of libfm-qt in the README file
- Update `archivers.list` and `lxqt-archiver` after recent changes in some MIME type strings HOT 6
- Add "Downloads" to places menu HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libfm-qt.