film-task-webbylab's People
film-task-webbylab's Issues
This part maybe must be out of component in middleware
Not the best parse flow
In the current case, u use replace twice, then split. Why not split by this triggers & get data on each step in mush easier way?
// split each film;
let films = srt.split(DOUBLE_WRAPLINE);
// parse each film
films = films.map(film => {
const filmObj = film.split(SINGLE_WRAPLINE).reduce((acc, line) => {
const [name, value] = line.split(': ');
acc[name] = value;
return acc;
}, {})
filmObj.starts = filmObj.starts.split(', ');
return filmObj;
})
and here we have all parsed.
Not sure what sending each item separate is a good idea
Rewriting argument variable is not the best practice. Also if U use slit, that already array, not string, so logically we have issue too
Check response status before delete from store
Not nice to use index as key
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.