Giter Club home page Giter Club logo

Comments (3)

caglar10ur avatar caglar10ur commented on June 14, 2024

Have you tried calling Acquire (

// Acquire increments the reference counter of the container object.
) ?

from go-lxc.

caglar10ur avatar caglar10ur commented on June 14, 2024

We could also do following (not tested)

diff --git a/lxc-binding.go b/lxc-binding.go
index a45648f..d01d3c0 100644
--- a/lxc-binding.go
+++ b/lxc-binding.go
@@ -116,12 +116,12 @@ func ContainerNames(lxcpath ...string) []string {
 
 // Containers returns the defined and active containers on the system. Only
 // containers that could retrieved successfully are returned.
-func Containers(lxcpath ...string) []Container {
-       var containers []Container
+func Containers(lxcpath ...string) []*Container {
+       var containers []*Container
 
        for _, v := range ContainerNames(lxcpath...) {
                if container, err := NewContainer(v, lxcpath...); err == nil {
-                       containers = append(containers, *container)
+                       containers = append(containers, container)
                }
        }
 
@@ -151,12 +151,12 @@ func DefinedContainerNames(lxcpath ...string) []string {
 
 // DefinedContainers returns the defined containers on the system.  Only
 // containers that could retrieved successfully are returned.
-func DefinedContainers(lxcpath ...string) []Container {
-       var containers []Container
+func DefinedContainers(lxcpath ...string) []*Container {
+       var containers []*Container
 
        for _, v := range DefinedContainerNames(lxcpath...) {
                if container, err := NewContainer(v, lxcpath...); err == nil {
-                       containers = append(containers, *container)
+                       containers = append(containers, container)
                }
        }
 
@@ -186,18 +186,19 @@ func ActiveContainerNames(lxcpath ...string) []string {
 
 // ActiveContainers returns the active containers on the system. Only
 // containers that could retrieved successfully are returned.
-func ActiveContainers(lxcpath ...string) []Container {
-       var containers []Container
+func ActiveContainers(lxcpath ...string) []*Container {
+       var containers []*Container
 
        for _, v := range ActiveContainerNames(lxcpath...) {
                if container, err := NewContainer(v, lxcpath...); err == nil {
-                       containers = append(containers, *container)
+                       containers = append(containers, container)
                }
        }
 
        return containers
 }

which also silences the go vet error (shallow copy copies the underlying mutex)

from go-lxc.

caglar10ur avatar caglar10ur commented on June 14, 2024

Now that #86 is merged, I'm closing this

from go-lxc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.