texture submit; need a way to specify target about alpha HOT 9 CLOSED

Hmm, first off - the TextureType and TextureSubmitTarget function as Int, meaning you can use GL_TEXTURE_EXTERNAL_OES (0x8D65) in place of a typed value as an Int and it will work just fine. Secondly, submit is only called in new, you haven't described the usage pattern enough to see the problem yet.

So if you call submit yourself with the right arguments, they don't have to be part of the enum to be passed in, what is the issue? Are you calling new every time or something?

from alpha.

ok, I didn't investigate thoroughly before posting. Here it is "real problem"

Basically the offending code is as simple as:

renderTexture = new RenderTexture({
	id: 'rt',
	width: 512,
	height: 512,
	type: 0x8D65, // GL_TEXTURE_EXTERNAL_OES
});

In the constructor of RenderTexture, it calls submit(null)

And then fails here

Basically the options.texture == null check is useless, because one is always created in the super() call.

And there is no way to make it call submit with a the correct target, which is the problem.

Point 1 & 3 of OP can be mitigated by user code. But point 2 is not, as described above.

from alpha.

right so, the texture handle needs to exist, so the call to super is ok. Call submit yourself immediately after new?

from alpha.

I'm trying to understand the actual problem you see, not the conceptual issue in the code, but the side effect of it.

from alpha.

The actual problem is, write this piece of code, then it crashes.

new RenderTexture({
	id: 'rt',
	width: 512,
	height: 512,
	type: 0x8D65, // GL_TEXTURE_EXTERNAL_OES
});

from alpha.

I tidied up the submit in this branch but since I can't test it with that texture type you'll have to test

from alpha.

Sure I will test it. Thanks!
But I also wonder isn't adding a submitTarget field to TextureOption more convenient?

from alpha.

Not really, the type is meant to be inferred from the TextureType, and TextureType is supposed to be (but isn't yet) an abstraction, which would mean that having GL concepts hardcoded in the API which I was trying to avoid

from alpha.

I tidied up the submit in this branch but since I can't test it with that texture type you'll have to test

Yes I can confirm it works now, thanks!

from alpha.