Callback positions about luv HOT 4 CLOSED

i vote for last function argument. It seems consistent with nodejs.

from luv.

I don't care about consistency with node.js in luv since the goal here is to expose libuv to lua in the way that's best for lua. But I do agree that many of the reasons node put callbacks last applies here too. Lua has first-class anonymous functions that can be inlined in the arguments list. Last makes it look like an indented continuation with all the other parameters coming first.

from luv.

Usually I'd say follow the C API because it makes documentation/user transition easier, unless Lua offers a way to make it much nicer (just like using coroutine yields instead of one-shot callbacks where possible). In this case though I think they just went wrong with the C API, and the 2nd option (callback as last argument) definitely looks better.

from luv.

Thanks for the feedback, I'll put it last.

from luv.