Add proper error reporting to event handlers about luv HOT 6 CLOSED

I suggest doing this in the libuv style(reporting the status to Lua but convert it to error message string first)

from luv.

sounds good.

from luv.

But between the three style you said in the issue I opened, I prefer the second one.

from luv.

I would have thought you liked the first one. For the connect event, for example, there is no data, but there might be an error. So to do assert style I would have to create a truthy result like true for the non-error case. Success would be (true) and error would be (nil, "error message"). But with the first style it would be (nil) for success and ("error message") for error.

from luv.

I thought the 2nd style is just what other Lua libraries do for example, LuaSocket's connect returns nil plus error or true. But now I thought assert is not always used because the callbacks are invoked by uv.run and assert will cause error at the main loop so the service will down. It is convient for the return values to use the assert style but not callbacks. So I now changed to prefer the 1st style. Sorry to bother you.

from luv.

The current style is as follows:

Any libuv function that returns an int status is assertable on the lua side.

Any callback with status in it will inject an error at the front of the callback list.

callbacks related to handles do have the handle before the err as self. So for example, timers look like:

uv.timer_start(uv.new_timer(), 1000, 0, function (timer)
end)

And TCP Connect looks like:

local req = uv.tcp_connect(uv.new_tcp(), "localhost", 1337, function (handle, err)
end)

from luv.