Issue with 0.13.0 about apache_exporter HOT 12 CLOSED

Apologies, looks like we need more automated testing!

I'll set the release back to pre release

from apache_exporter.

no worries - looking for the next version then. thanks!

from apache_exporter.

Another report, just to give you some variety of platforms:

    Virtualization: vmware
  Operating System: CentOS Stream 8
       CPE OS Name: cpe:/o:centos:centos:8
            Kernel: Linux 4.18.0-448.el8.x86_64
      Architecture: x86-64

from apache_exporter.

Found the issue, this PR upstream should resolve it prometheus/exporter-toolkit#127

It can be locally fixed as well by specifying the new parameters.

from apache_exporter.

@Lusitaniae, We opened a PR #149 feel free to add changes. We will still need a follow up PR to improve tests.

from apache_exporter.

The real issue is that the newer exporter-toolkit version is not really being used in an optimal way by apache_exporter.

A kingpinflag.AddFlags helper function adds the web.listen-address, web.config.file and web.systemd-socket (if GOOS = linux), and will populate a web.FlagConfig struct to be passed to web.ListenAndServe.

Admittedly, this would mean breaking / renaming the existing telemetry.address and web.config flags which are explicitly added by apache_exporter.

from apache_exporter.

Re released 0.13.0 if you'd like to try it @swiffer @corporate-gadfly

Any suggestions for the proper fix @dswarbrick ?

from apache_exporter.

@Lusitaniae thanks - for now working fine!

from apache_exporter.

@Lusitaniae Take a look at how node_exporter uses it - but as I say, beware that some flag names will change. I can submit a PR if you're ok with that.

from apache_exporter.

@dswarbrick A PR would be great. Thanks!

from apache_exporter.

Released 0.13.1 with #149

if anyone would like to test would be appreciated

from apache_exporter.

We tested and released this to prod. It's working. 🎉

from apache_exporter.