Kibana basedir doesn't pick up attribute overrides about chef-logstash HOT 7 CLOSED

@sfiggins I don't suppose you are familiar with bats tests? https://github.com/sstephenson/bats

Test Kitchen 1.0 / Jamie has that plugin and might make it easy to test, though it would depend on attribute data in .kitchen.yml

from chef-logstash.

Ack I was distracted and missed the ask. If you could whip up a quick bats tests, that would be really helpful!

My best guess is you're looking at something like

@test "when the kibana attributes are set, it should install in that directory" {
  [ -d "/opt/kibana/foo" ]
}

from chef-logstash.

@sfiggins I have been considering switching our kibana integration out for Berkshelf + https://github.com/jbrook/chef-kibana-ruby. Does that implementation get you any further?

from chef-logstash.

Also, for agents, I highly suggest https://github.com/hectcastro/chef-lumberjack, based on https://docs.google.com/spreadsheet/ccc?key=0Aq9liCTsAyzRdDFEcUp2bjJPMTQzU1ZVTndTVzFwV3c#gid=0

from https://twitter.com/jordansissel/status/302294195945738240

from chef-logstash.

I haven't ever used bats. I'm not sure that's what I would want to test in bats though. When the kibana attributes are set it does install in the directory I set. I actually routed around the problem by setting defaults for the kibana directories in my role. (I had to set both ['logstash']['kibana']['basedir'] and ['logstash']['kibana']['home'] )

My expectation was that I would not have to set them if I wanted them to go under my logstash basedir. But when I set ['logstash']['basedir'] in my role defaults or overrides that setting wasn't reflected in kibana's directory attributes.

Somehow I would want to test "if you set ['logstash']['basedir'] in a role or recipe to something other than "/opt/logstash" and do not explicitly set the kibana directories, then kibana should install under the final value of ['logstash']['basedir']/kibana" instead of /opt/logstash/kibana"

My guess is the problem occurs because kibana's directory attributes are set off of the node['logstash']['basedir'] before role or recipe ['logstash']['basedir'] settings have been applied. That may be a chef error, or maybe an error in my expectation that the node value will reflect all these other settings when evaluated instead of just cookbook attribute default values.

from chef-logstash.

Hey Stephen,

I believe this is a chef issue and chef 11 should fix it

On Tue, Feb 19, 2013 at 6:42 PM, Stephen Figgins
[email protected]:

I haven't ever used bats. I'm not sure that's what I would want to test in
bats though. When the kibana attributes are set it does install in the
directory I set. I actually routed around the problem by setting defaults
for the kibana directories in my role. (I had to set both
['logstash']['kibana']['basedir'] and ['logstash']['kibana']['home'] )

My expectation was that I would not have to set them if I wanted them
to go under my logstash basedir. But when I set ['logstash']['basedir'] in
my role defaults or overrides that setting wasn't reflected in kibana's
directory attributes.

Somehow I would want to test "if you set ['logstash']['basedir'] in a role
or recipe to something other than "/opt/logstash" and do not explicitly set
the kibana directories, then kibana should install under the final value of
['logstash']['basedir']/kibana" instead of /opt/logstash/kibana"

My guess is the problem occurs because kibana's directory attributes are
set off of the node['logstash']['basedir'] before role or recipe
['logstash']['basedir'] settings have been applied. That may be a chef
error, or maybe an error in my expectation that the node value will reflect
all these other settings when evaluated instead of just cookbook attribute
default values.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/75#issuecomment-13786257.

from chef-logstash.

closing this as we've removed kibana.

from chef-logstash.