Comments (4)
luser-dr00g
commented on June 14, 2024
Yes, it looks like it's not used anymore so it isn't needed.
I think it got removed when we switched to an environment variable to find
the /data directory instead of trying to find the path to the executable
and finding the relative path from there.
It can be removed.
…On Sun, Sep 19, 2021 at 1:52 AM vtorri ***@***.***> wrote:
in configure.ac, i can see:
if ! test "x${ac_cv_func_dirname}" = "xyes" ; then
AC_MSG_ERROR([dirname() function is mandatory, exiting...])
fi
but dirname() is not used at all (git grep dirname)
should we remove that check ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#52>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSMFVY7WRFQ4Y3LKLVCXZDUCWCCTANCNFSM5EKAOBVA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from xpost.
vtorri
commented on June 14, 2024
and I guess that libgen.h check can also be removed. I think that it was for dirname()
from xpost.
luser-dr00g
commented on June 14, 2024
Yes, it looks like the only things available in libgen.h are basename() and dirname(). Oracle appears to have a special version with lots of crazy functions and the Posix version may have once held regcmp() and regex(). But yeah, we're not using any of that stuff.
Just using the ENV made everything so much easier. :)
from xpost.
vtorri
commented on June 14, 2024
fixed in git
from xpost.
Related Issues (20)
- Increase performance of the hash tables HOT 1
- use the same random filename sequence in lmem* gmem* and xdump* HOT 2
- create dumper utility to convert lmem* gmem* and xdump* to a text format HOT 3
- optimize typechecks and polymorphic dispatch from procedure bodies in `bind`
- unit tests do not compile on Windows HOT 3
- color space not changing naturally
- Increase array and string max size
- Simplify operator execution by pushing args backwards HOT 1
- Remove integer automaton from grok()
- kshow ignores proc
- devices which output to file only output a single file (jpeg png pgm ppm) HOT 4
- PS interpreter HOT 6
- Completion of error handling HOT 16
- readhexstring has multiple problems HOT 4
- [discussion] meson build system HOT 2
- xpost_file_read(), and hence readstring, doesn't deal with end of file HOT 2
- -Wall has a new nuisance warning HOT 18
- Configuration parameters HOT 2
- Can't install HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xpost.