Comments (14)
Thanks! I will add CSD support when it's available, of course, but I just checked and it's not available on FF nightly (59.0a1-20171207100053) yet. The key is not present and when I add it manually, it does nothing. I'll take a look at Fedora's patched version when it finishes downloading and see what I can do.
from firefox-gnome-theme.
@rafaelmardojai BTW today I discovered that Firefox has a pseudo-class to detect whether the window has focus or not: :-moz-window-inactive
. GNOME styles inactive windows differently, all buttons and gradients become flat, so I added that feature too! :D Commit 94e3946, looks like this:
(An active and an inactive window.)
I added all the styles to my GNOME 3.18 themes, but not your 3.26 one, because I don't know how is it supposed to look like. If you want, you can add them too (just replace variables starting with --gnome-inactive-
in the gnome-3.26-dark.css
file, if they are different than for active windows). If you need a solid color for a variable which expects an image (or gradient), you can use a gradient with two identical colors, eg.
:root {
--gnome-inactive-example-bgimage: linear-gradient(#fff, #fff);
}
from firefox-gnome-theme.
@kurogetsusai I am working on it (i use fedora), i will share it when is finished.
Styles from https://git.gnome.org/browse/gtk+/plain/gtk/theme/Adwaita/gtk-contained-dark.css.
from firefox-gnome-theme.
Please, test the progress here https://github.com/rafaelmardojai/firefox-gnome-theme/
Currently only work for Adwaita-dark.
For window buttons options edit userChrome.css
.
from firefox-gnome-theme.
Okay so looks like I can't run Firefox' dev tools in a virtual machine, because the whole VM just freezes. When I run Fedora's Firefox in a VM using the host system's X server via ssh it doesn't crash immediately, still lags so hard it's barely usable, but I managed to write this piece of code. Looks like this:
It's still broken in many ways, works only for the close button and only if it's on the right side, the separator between window controls and the rest of the buttons is missing and there's still visible a horizontal bar at the top of the window if the window is maximized. I have no idea what to do about those problems, but I'll take a look at it when I have some free time again. For now I hope this patch makes it a bit more usable.
You need to enable this module in the userChrome.css
file if you wanna use it.
from firefox-gnome-theme.
Looking great already! :)
from firefox-gnome-theme.
That looks awesome on your screenshots, good job! I can't really test it since I don't use Fedora, I managed to run it in a VM but it crashed after like 10 seconds. What's with that theme tho? It looks different than my dark Adwaita. I'm using GNOME 3.18.5, maybe we should add different versions too, since yours appears to be different? Only the variant files would be different, they only contain variables, not actual rules, currently we have two: theme-dark.css
and theme-light.css
, might as well rename them and add something like gnome-3.26-dark.css
or whatever Fedora uses.
Also I see you modified other files too, not just fedora-csd.css
, which breaks a lot of things if CSD is disabled or if you run it on others distros.
from firefox-gnome-theme.
Also I noticed Mozilla added native CSD support to Firefox Nightly (at least it is present in FF 59.0a1-20171214220032), but it's not the same patch that Fedora uses. It can be enabled by going to Customize → uncheck the Title Bar option. Since it's different than Fedora's patch, the styles @rafaelmardojai wrote need some adjustments to work with FF Nightly properly. I'll correct them later, when we have a stable-ish code for Fedora's CSD, since FF Nightly is something I can test and debug. For now it looks like this:
from firefox-gnome-theme.
@kurogetsusai, yes i customized it to match 3.26. I edited theme.css
to add the variable --gnome-headerbar-button-bottom-border-color
to follow 3.26 design (buttons have a diferent border color at the bottom), nothing is break with CDS disabled.
Maybe for Firefox Nightly CSD we should add csd.css
(i think is the same patch of Fedora made by Martin Stransky but more updated).
I'm working on Firefox Nightly now (i think my fedora-csd.css
is enough stable for Fedora Firefox 57 users).
Regards!
from firefox-gnome-theme.
Hey!
I just updated my fork, with your new changes, and Firefox Nightly CSD support.
from firefox-gnome-theme.
Well, that's pretty much done, so I'll merge your changes into my repo. Well done, you're good at this. 😛
from firefox-gnome-theme.
Merged, fixed minor bugs, tested all color variants on FF 57, 58, 59, everything seems to work (CSD works only on 59 and 57 with Fedora's patch, of course), so I'm closing this. Thanks again! :D
from firefox-gnome-theme.
@rafaelmardojai, can you also create a light version of the 3.26 theme? Thanks for your work!
from firefox-gnome-theme.
@d9h20f of course, when i have some free time i will do it.
from firefox-gnome-theme.
Related Issues (20)
- theme api 'toolbar_text' element changes color of toolbar text HOT 1
- Location bar hidden in fullscreen (F11) mode when mouse hovered over HOT 2
- csd buttons left option? HOT 2
- Support third party GTK+ themes HOT 3
- [Feature Request] Create Matching Firefox Color Profiles HOT 1
- HiDPI support for some icons HOT 8
- Faint circle (from default Firefox theme) when hovering over back button HOT 2
- Close Button on Firefox 65 Is Larger than the CSD HOT 13
- Doesn't work at all with CSDs on Firefox 65 HOT 8
- Support new GNOME 3.32 theme HOT 18
- Fullscreen bugs HOT 2
- Bookmark bar above tabs? HOT 3
- CSD Buttons on the Left HOT 4
- Heads up: userContent/userChrome to be gated by default-off pref
- Context menu theming HOT 1
- Volume and close button too close?
- Discontinue parts of the project HOT 10
- Question: Buttons in window without the titlebar HOT 2
- Quit Minimize ect... buttons displayed on a little bar on the top of url adress HOT 1
- The authorization popup for allowing use of camera and micro won't show HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefox-gnome-theme.