Comments (5)
The offending rule is:
#back-button > .toolbarbutton-icon {
width: 30px !important;
}
The standard rule from browser.css is:
#back-button > .toolbarbutton-icon {
width: calc(2 * var(--toolbarbutton-inner-padding) + 16px);
}
This results in a computed value of 26px (16px, plus 5+5px padding) instead of 30px.
I think you'll find that the "some systems" seeing this problem have "Compact" density selected in Firefox's "Customise" UI instead of "Normal" - removing the above rule fixes the oversized/blurry icon in that case ;)
On the other hand, with "Normal" density the back icon looks undersized without the 30px rule.
HTH
from firefox-gnome-theme.
Hey, you're totally right. With this theme, the density is no longer important, so changing it back to 'Normal' permanently fixes the issue.
from firefox-gnome-theme.
I can confirm that, i noticed the same behavior.
from firefox-gnome-theme.
I just checked, the back arrow is pixel-identical with either normal density + rule or compact density + no rule.
Maybe make the rule conditional on the current density, if there's a CSS attribute/class for it?
from firefox-gnome-theme.
Well then I'd say just switching to normal density is a good solution. Compact and touch density aren't supported anyway, they break paddings in more places than just this icon and when you switch to touch density everything looks bad. All the icons are underscaled, all buttons are fat, tab close buttons shrink to like 1px high.
I would rather focus on expanding support to Firefox 58, which is gonna be released on January 28, than debugging everything to fix those paddings which can be disabled in 2 clicks by the user and are disabled by default anyway. Also I noticed the icon is still too small even using normal density on Firefox 58+, so that's something which must be fixed before the FF58 release. Also on FF58 the headerbar isn't high enough (probably the reason why the styles for Fedora's CSD patch don't exactly work with FF59) and disabled buttons look too flat. I'll try to fix all these in January. As for Firefox 57, the problem doesn't exist if you use normal density, so I'd say the issue is resolved.
Thank you all for figuring this out and testing the solution, I totally forgot about that density switch.
from firefox-gnome-theme.
Related Issues (20)
- theme api 'toolbar_text' element changes color of toolbar text HOT 1
- Location bar hidden in fullscreen (F11) mode when mouse hovered over HOT 2
- csd buttons left option? HOT 2
- Support third party GTK+ themes HOT 3
- [Feature Request] Create Matching Firefox Color Profiles HOT 1
- HiDPI support for some icons HOT 8
- Faint circle (from default Firefox theme) when hovering over back button HOT 2
- Close Button on Firefox 65 Is Larger than the CSD HOT 13
- Doesn't work at all with CSDs on Firefox 65 HOT 8
- Support new GNOME 3.32 theme HOT 18
- Fullscreen bugs HOT 2
- Bookmark bar above tabs? HOT 3
- CSD Buttons on the Left HOT 4
- Heads up: userContent/userChrome to be gated by default-off pref
- Context menu theming HOT 1
- Volume and close button too close?
- Discontinue parts of the project HOT 10
- Question: Buttons in window without the titlebar HOT 2
- Quit Minimize ect... buttons displayed on a little bar on the top of url adress HOT 1
- The authorization popup for allowing use of camera and micro won't show HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefox-gnome-theme.