lum-network / chain Goto Github PK

the import ordering formatter is affecting .pb.go files (in ci) and it shouldn't

While examining this repository for security issues, I noticed that the code for GenerateSecureToken

uses a pseudo-random generator in math/rand of which even the GoDoc for the package explicitly says https://pkg.go.dev/math/rand and even if seeded, its outputs can be predicted

Even more, this code uses the global reader with a very weak seed of time.Now().UnixNano() which an attacker can properly trivially find; also it mutates the global pseudo-random reader which makes for even worse predictable state.

This can be a serious security issue.

Suggestion

Please use a stronger source of randomness like crypto/rand and just invoke crypto/rand.Read(seed)

/cc @elias-orijtech @veorq

The Cosmos SDK team has notified the community that a high-severity security issue patch will be released on June 8th, 16:00UTC. I am contacting you because your network is running an impacted version of the Cosmos SDK and to give advanced notice to prepare for security patch coordination. The patch can be applied without a consensus upgrade and will require at least 33.3% of the validators to update their nodes as quickly as possible to protect the network from exploitation.

When the Cosmos SDK patch is available, it is the responsibility of each network to validate it as quickly as possible, have a security release for the network binary as soon as possible, and coordinate with the network validators to upgrade their nodes as early as possible.

I am contacting you here because there was no e-mail address listed in the SECURITY.MD file for the repository and the HackerOne link listed points to an invalid page. Please populate a SECURITY.MD file with the relevant information (e-mail address) for subsequent reach-outs regarding security updates.

You can find more information on the link above.

Currently the lumd keyring default backend is set to test instead of file, which is not recommended for production.

This must be a compile time option as there is no config option for it, and as it seems it's not possible to switch from one backend to another without using the --keyring-backend flag with every command that requires key access.