MacOS version about blitz-app-adblock HOT 15 CLOSED

I tried the new 3.0.0 release and it seems to work! Cheers, thanks for helping :D

from blitz-app-adblock.

No problem, and thank you for helping me debug all this to work on macOS. Cheers!

from blitz-app-adblock.

It is very possible, the patcher can be ported over to .NET Core for cross platform compatibility.

However I currently do not have a MacOS computer so I wouldn't be able to get that done any time soon. Maybe someone else could give it a try.

from blitz-app-adblock.

I am actually in the process of rewriting the patcher in Node.js which will make it cross-platform.

If you could provide the full file location of app.asar, I could probably get it to work on MacOS.

from blitz-app-adblock.

Full path on Mac appears to be: /Applications/Blitz.app/Contents/Resources/app.asar

from blitz-app-adblock.

I have just released the Node.js patcher, allowing it to theoretically work on MacOS.

You can also compile and debug it for yourself using npm and Node.

Let me know if it works out.

from blitz-app-adblock.

It doesn't seem like it's working. I'm running into errors both running the macOS patcher and also trying to compile it myself. I'm not too familiar with these packages, is something wrong on my end?

Running .out file

Compiling myself

from blitz-app-adblock.

Have you tried npm run start and see if that does anything? If that works then must be something related to the pkg module.

from blitz-app-adblock.

npm run start returns an error as well

from blitz-app-adblock.

I think line 11 of blitz-app-adblock.js is creating the error.

I believe in the first argument of path.join(), process.env.APPDATA is undefined on macOS. Try initializing appPath to be an empty string instead and see if that does it.

from blitz-app-adblock.

That fixed part of the issue. Another issue was that unix systems use forward slashes in file paths while windows uses backslashes so it wasn't finding the right file. Changing it to the code below helped it find app.asar but now I get:

        // mac os app path
        if (process.platform === "darwin") {
            appPath = '/Applications/Blitz.app/Contents/Resources';
        }

        if(!fs.existsSync(`${appPath}/app.asar`)) {
            console.log("app.asar not found!");
        }
        else {
            console.log('Extracting app.asar...');
            await asar.extractAll(`${appPath}/app.asar`, `${appPath}/app/`);

from blitz-app-adblock.

Also I'll note that this slash issue also applies to the npm run build issue. Changing .\build\ to ./build/ causes this instead:

from blitz-app-adblock.

What node version are you using? It might only be working on my old node 10.16.3. I'll try updating in a bit and seeing if the same problem occurs.

from blitz-app-adblock.

It appears that node 15 is not supported by pkg. I think I'll update to node 14.15.4 (latest LTS version) and see if that works.

from blitz-app-adblock.

Try pulling the latest changes and use node 14.15.4 to compile. I also re-uploaded the 3.0.0 release with all the changes if you want to test that first.

from blitz-app-adblock.