SmtpSender disposes itself after first send about fluentemail HOT 6 CLOSED

I agree that we should be able to pass our own SmtpClient and it should not be disposed by the Send method.
So, I created #98 to fix this.

from fluentemail.

@anthonyvscode, I'm CC'ing you since you were recently working on that code. You didn't cause the bug AFAICS, though you may have insight into this issue?

from fluentemail.

you need to new up the client every time you Send() also, if you want to re-use the client you'll need to write your own SmtpSender, looking at the code its trivial

from fluentemail.

Yep, those are two workarounds for the bug -- I'm doing the former.

from fluentemail.

Hello! It seems to me that it is not a good idea that default SmtpSender hides information about the disposing the internal smtp client - this is not obvious to the consumer (ie to the developer). Maybe, ISender should also be IDisposable?

from fluentemail.

#89 now spins up and disposes the SmtpClient using the given function. Not ideal, but not broken.

from fluentemail.