Reconnections are not being queued. about sockette HOT 3 CLOSED

I've figured out that I'm not getting ECONNREFUSED from the connection attempt, so that is clearly the issue. Not really a problem when things go to production and the backend is long-running, but in development that's going to be a hassle.

I suppose I could just manually trigger a reconnect to workaround this for the moment. E: Nevermind, it doesn't attempt to reconnect even when triggering it manually, as it still thinks it's hit the maximum number of attempts already.

E2: After further tinkering (read: editing dependencies manually) and manually attempting a reconnect, it seems that the current number of attempts is undefined inside the library's own onreconnect handler, then becomes NaN. Left is num, right is maxAttempts:

This makes sense, as the connection is never opened, so onopen is not called, and so num is never initialized to 0. Can confirm that initializing num to 0 allows for this workflow.

from sockette.

IMO, this makes sense, unless I'm missing something here?

You can only re-connect after having connected in the first place.

Initializing num=0 at the start would fix this for you, but I feel like it's encouraging lack of error handling. You should definitely be handling ECONNREFUSED & the like manually, or kill the process. That's what the hooks are intended for, really.

It'd be much worse to (potentially) indefinitely ping your server that's shut down or choking.

What do you think?

from sockette.

Hey @sli – it looks like you edited your response after I replied, so I never saw that last portion (and was never notified)

Are you saying that the fix was to declare num=0 at the top of the constructor?

from sockette.