Comments (10)
@isaacwashere I noticed a small bug that I didn't see in dev. If you switch between sort options a few times, there's one repo that gets stuck on top and gets duplicated every time you switch.
![Screenshot 2023-05-15 at 16 08 33](https://private-user-images.githubusercontent.com/14332663/238374722-d5638dbe-bce6-4c14-bf7d-f78a860120d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5Njg3MDksIm5iZiI6MTcyMzk2ODQwOSwicGF0aCI6Ii8xNDMzMjY2My8yMzgzNzQ3MjItZDU2MzhkYmUtYmNlNi00YzE0LWJmN2QtZjc4YTg2MDEyMGQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDA4MDY0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0Mjc0OTU4NzJmOTY0ZmFhYzBlZTMxYzExZDlkZDk4MmI0N2EwNzNjNmJiZGFkZTNkODNiZmU1Y2U5YjVlY2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.mHvnZuoJaMOyIg8AikgZiyUSLAc9_uSVT_QVNvajG-Y)
from verto.
Will check it out!
from verto.
I will try to solve this issue
from verto.
@lucavallin WOAH I did not see that bug when working on this locally, and I made sure to do weird toggles between the 2 star buttons.
I have a hunch that it could be the slicing that's happening in the RepositoryList
but tbh I'm not sure how to repro this locally. I'll see if maybe I can do a prod-level GitHub query 🤔 Maybe I need more data. But yea, this is weird, and I'll try to look into it today 👍
from verto.
I've put up a PR for that bug #114 👍
from verto.
I would like to work on this issue. please assign me this issue.
from verto.
@lucavallin
As of now there is a sort by stars (most, least) in two separate buttons, I thought It would useful to make it as one "Sort by stars" button that change order (ascendant, descendant) every click.
Another Sort by button that would be useful to check which repos are maintained is the Sort by Activity also in two different oreders so we can sort repos by last activity.
from verto.
Opened a PR for this issue
from verto.
Sort by stars and the architecture needed for that and future sorting has already been address in #112 by @isaacwashere .
from verto.
@nrhitik Thanks for your interest. Please go ahead ;)
from verto.
Related Issues (20)
- Implement search with Algolia HOT 5
- Move tests out of data directory
- Address pagespeed results. HOT 4
- Linkedin link broken. HOT 1
- Suggestion: add tag for documentation needs HOT 3
- Store and read data from a database instead of a JSON file HOT 12
- Let users register HOT 4
- Fix favicons HOT 3
- Search repos by multiple tags HOT 4
- Implement / fix user pages
- Enhancing Button Styles for an Attractive Look
- Add animation to SortPicker Component
- Fix the data/get.ts link in the README.md HOT 1
- Add an Issue template
- Update the "Your First Code Contribution" section of the README.md file HOT 1
- Update the "Improving The Documentation" section of the README.md file HOT 1
- Update the "Commit Messages" section of the README.md file
- Update the "Join The Project Team" section of the README.md file HOT 2
- Update all dependencies to the latest version HOT 3
- Check SEO
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verto.