Giter Club home page Giter Club logo

Comments (10)

lucavallin avatar lucavallin commented on August 18, 2024 2

@isaacwashere I noticed a small bug that I didn't see in dev. If you switch between sort options a few times, there's one repo that gets stuck on top and gets duplicated every time you switch.

Screenshot 2023-05-15 at 16 08 33

from verto.

thebarshablog avatar thebarshablog commented on August 18, 2024 1

Will check it out!

from verto.

tamiresviegas avatar tamiresviegas commented on August 18, 2024 1

I will try to solve this issue

from verto.

isaacwashere avatar isaacwashere commented on August 18, 2024 1

@lucavallin WOAH I did not see that bug when working on this locally, and I made sure to do weird toggles between the 2 star buttons.

I have a hunch that it could be the slicing that's happening in the RepositoryList but tbh I'm not sure how to repro this locally. I'll see if maybe I can do a prod-level GitHub query 🤔 Maybe I need more data. But yea, this is weird, and I'll try to look into it today 👍

from verto.

isaacwashere avatar isaacwashere commented on August 18, 2024 1

I've put up a PR for that bug #114 👍

from verto.

nrhitik avatar nrhitik commented on August 18, 2024 1

I would like to work on this issue. please assign me this issue.

from verto.

iaminebriki avatar iaminebriki commented on August 18, 2024 1

@lucavallin
As of now there is a sort by stars (most, least) in two separate buttons, I thought It would useful to make it as one "Sort by stars" button that change order (ascendant, descendant) every click.
Another Sort by button that would be useful to check which repos are maintained is the Sort by Activity also in two different oreders so we can sort repos by last activity.

from verto.

JacobRosey avatar JacobRosey commented on August 18, 2024 1

Opened a PR for this issue

from verto.

lucavallin avatar lucavallin commented on August 18, 2024

Sort by stars and the architecture needed for that and future sorting has already been address in #112 by @isaacwashere .

from verto.

lucavallin avatar lucavallin commented on August 18, 2024

@nrhitik Thanks for your interest. Please go ahead ;)

from verto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.