Comments (7)
Do you mean where to create the log file with the actual logs, or where to log the data inside the code? 🤔
For the file, I thing we can stick with console.log
as it's already used. For where to do the logging I think the best place would be on the last execution block inside data/get.ts
, right before the sitemap build 🤔
But I'm sure @lucavallin would be able to tell you if that's ok or if there are better ways/places 🙂
from verto.
Hey @zillemarco, sounds interesting. It will definitely simplify the filtering process. Where would you like that to be logged?
from verto.
@dnafication agree with @zillemarco. We just need a way to see repos that don't meet criteria (anymore). Maybe in the Actions workflow summary would be a reasonable place for that.
from verto.
Great! I have some ideas around refactoring the get.ts
file and making it modular and more readable. I'll include the logging changes there. I'll send a PR soon.
from verto.
Hey @lucavallin @zillemarco, I was thinking of introducing .env
file to the project and add all these vars below and more to the file.
REPOS_PER_REQUEST=25
MAX_ISSUES=10
GH_PERSONAL_ACCESS_TOKEN=
... any others in the future
@lucavallin you might need to update Vercel's deployment config to support these changes so let me know if its worth a change.
from verto.
At first, my idea was to record comprehensive information regarding why a repository didn't meet the criteria. However, it appears that filtering occurs at various stages, such as during the GraphQL query and subsequent processing of its results.
Now, I'm planning to generate a comparison between the original list and the filtered list and logging only that information. Do you believe this would suffice, or should we still include specifics about why a particular repository failed to meet the criteria?
Perhaps, this can be the initial iteration and we can add more logic to it. I have made the code modular and refactored the main script to make it readable. I'll send the PR soon.
from verto.
@dnafication I am happy to add the .env
file, but first, what problem does it solve?
For the rest, all good. I think a list of repositories filtered out without details is fine for now.
from verto.
Related Issues (20)
- Implement search with Algolia HOT 5
- Move tests out of data directory
- Address pagespeed results. HOT 4
- Linkedin link broken. HOT 1
- Suggestion: add tag for documentation needs HOT 3
- Store and read data from a database instead of a JSON file HOT 12
- Let users register HOT 4
- Fix favicons HOT 3
- Search repos by multiple tags HOT 4
- Implement / fix user pages
- Enhancing Button Styles for an Attractive Look
- Add animation to SortPicker Component
- Fix the data/get.ts link in the README.md HOT 1
- Add an Issue template
- Update the "Your First Code Contribution" section of the README.md file HOT 1
- Update the "Improving The Documentation" section of the README.md file HOT 1
- Update the "Commit Messages" section of the README.md file
- Update the "Join The Project Team" section of the README.md file HOT 2
- Update all dependencies to the latest version HOT 3
- Check SEO
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verto.