Comments (18)
Hi, @lucavallin
hope this comment find you in good health
I would like to contribute and resolve the problem , could you please explain the issue in detail that you want to center the 404 tag or you like to change the whole ui of the page??
from verto.
I think you should make a new custom 404 page, if there is anything wrong happen then redirect to that page.
from verto.
Can I work on this issue
from verto.
@Jagpreet153 It could be centered, that would already make it better. Alternatively, it could be something different, for example we could show an empty repository list. @Vivek-04022001 @AbhiPatel10 Feel free to sync with @Jagpreet153 to work on this ;)
from verto.
_how it looks, do you want to add something here @lucavallin . _ I have done some minor modification in tailwind.config file to get a 5xl text size. It's just a single line modification.
from verto.
I would like to request your design advice for mobile devices.
from verto.
I think you should make a different page for 404 and redirect to that page if something wrong happened.
from verto.
@AbhiPatel10 , okay i will try
from verto.
@lucavallin, please provide your recommendation. @AbhiPatel10 suggested redirecting to a new "not-found" page. Do you also prefer a redesign of the "not-found" component?
from verto.
Hey @Vivek-04022001! Given that the main layout shows filters for the repo list but on the 404 there are no repos, it probably makes sense to have a 404 page that shows only the 404 message.
from verto.
@lucavallin, sounds good! I'll create a separate page for the 404 error. Is there anything else you'd like me to consider?
from verto.
@lucavallin , is it looks good?
from verto.
But I'm afraid, the approach I have used is not good : can you please check the code ,right here
export default function App({ Component, pageProps }: AppProps) {
const router = useRouter();
const shouldRenderComponents = router.pathname === "/";
return (
<>
<Head>
<meta name="viewport" content="width=device-width, initial-scale=1" />
</Head>
<AppDataProvider>
<main className={`${inter.variable} font-sans`}>
{shouldRenderComponents ? (
<>
<SponsorsBar />
<Layout>
<Component {...pageProps} />
</Layout>
</>
) : (
// 👉Not found component renders only when the conditition is fullfilled.
<NotFound />
)}
</main>
</AppDataProvider>
</>
);
}
from verto.
Hey @Vivek-04022001 ! Yes, looks good, thanks for working on this! I have a few comments, please open a PR so I can add them there!
from verto.
@lucavallin , I have created the pull request. You can check my code now.
from verto.
@Vivek-04022001 add close #192 in your pr so Your pr will connected to this Issue
from verto.
@AbhiPatel10 , sorry I don't know how to do this? But I have created a pull request. Can you please check. Did i do something wrong?
from verto.
Hii, i am seeing that you want to make a 404 error page, please assign it to me , i will make it so much better.
from verto.
Related Issues (20)
- Implement search with Algolia HOT 5
- Move tests out of data directory
- Address pagespeed results. HOT 4
- Linkedin link broken. HOT 1
- Suggestion: add tag for documentation needs HOT 3
- Store and read data from a database instead of a JSON file HOT 12
- Let users register HOT 4
- Fix favicons HOT 3
- Search repos by multiple tags HOT 4
- Implement / fix user pages
- Enhancing Button Styles for an Attractive Look
- Add animation to SortPicker Component
- Fix the data/get.ts link in the README.md HOT 1
- Add an Issue template
- Update the "Your First Code Contribution" section of the README.md file HOT 1
- Update the "Improving The Documentation" section of the README.md file HOT 1
- Update the "Commit Messages" section of the README.md file
- Update the "Join The Project Team" section of the README.md file HOT 2
- Update all dependencies to the latest version HOT 3
- Check SEO
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verto.