[BUG] v4 uses `__wakeup`, which many plugins have overridden with an error. about wp-browser HOT 3 CLOSED

In the WPLoader module configuration set the backupGlobals, backupStaticAttributes to false; default value is true

This worked great, thanks.

from wp-browser.

Hi @BrianHenryIE,

the issue arises from the fact that, in v4, I've modified the WPTestCase::$backupGlobals to true; it was false in v3.

In your test cases, an immediate fix for the issue would be to explicitly override the WPTestCase::$backupGlobals property and set it to false.

I've set up a curated list of known offenders in the WPTestCase code, but cannot possibly cover it all.

Why change the $backupGlobals and $backupStaticAttributes properties of the WPTestCase from false (v3) to true (v4)? While the WPTestCase cleanup of global variables covers some, it will mainly cover the ones set and used by WordPress; globals and static properties frequently used to cache values will not be reset, leading to all kinds of difficult-to-track bugs and false results where tests are behaving differently depending on the run order.

Thinking about how to improve on this:

1. Add backupGlobals and backupStaticAttributes configuration parameters to the WPLoader configuration, default true, to control the behavior of the respective WPTestCase properties.
2. I like the sweeping cleanup done by the two properties and would like to be able to define what should not be serialized as part of the snapshot procedure PHPUnit uses to back up and restore the global state. I will add the backupGlobalsExcludeList and backupStaticAttributesExcludeList to the configuration of the WPLoader module to add to the respective lists.

In this API, your problem could be solved in two ways:

1. Disable backup of globals and static attributes:

   config:
     lucatume\WPBrowser\Module\WPLoader:
       backupGlobals: false
       backupStaticAttributes: false

2. Selectively exclude the problematic class:

    config:
      lucatume\WPBrowser\Module\WPLoader:
        backupStaticAttributesExcludeList:
          WC_Payment_Gateways: ['instance']

This API should provide a flexible approach to handle issues like this one.

from wp-browser.

I've followed up, in version 4.0.12 on this, to recap the possible approaches to solve the issue:

1. In the test case override the backupStaticAttributes or backupGlobals properties setting them to false; this could already be done in previous versions.
2. In the WPLoader module configuration set the backupGlobals, backupStaticAttributes to false; default value is true.
3. In the WPLoader module configuration set the backupGlobalsExcludeList and backupStaticAttributesExcludeList to add entries to the list of ignored globals and static attributes.

See docs.

from wp-browser.