Giter Club home page Giter Club logo

Comments (3)

alexmccord avatar alexmccord commented on June 7, 2024

Doesn't seem to be related to two modules specifically. It has to do with the table state of mod. For example, this repros.

--!strict
local function a()
    return { Start = function() end }
end

local mod = a()

type Service = {
    Start: () -> (),
    OnPlayerAdded: (player: Player) -> ()?,
}

local function Load(service: Service)
end

Load(mod)

from luau.

alexmccord avatar alexmccord commented on June 7, 2024

Oh I see the reason why this errors. Width subtyping and optional properties cannot go together. Here:

local function f()
  return { p = 5, q = "seven" }
end

local function g(t: { p: number, q: number? })
  t.q = 7
end

-- t : { p : number, q : string }
-- u : { p : number }
-- at runtime, u aliases t
local t = f()
local u = t :: { p : number }

g(u) -- at runtime, mutates q to have `7` (and consequently, t)

local q = t.q -- type system thinks `t.q` has type `string`, but at runtime it's a `number`.

So this is a valid error. The reason why the below doesn't produce any error

local t = { p = 5 }

g(t)

is because we have a special case that explicitly allows it. It even has a TODO for the first snippet I showed above.

https://github.com/luau-lang/luau/blob/master/Analysis/src/Unifier.cpp#L2165-L2170C10

from luau.

JohnnyMorganz avatar JohnnyMorganz commented on June 7, 2024

It is somewhat a shame that this is classified as invalid, as the original example seems like a reasonable piece of code. But I get that it is difficult to resolve soundly.

from luau.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.