Comments (6)
My idea would be to add a boolean parameter to the colorize function to control whether the background is highlighted or not. Is this acceptable, in your opinion?
from lsd.
I'm not a big fan of this kind of argument... What do you think of creating an Elem::SetuidFile
and a FileType::SetuidFile
like the Filetype::ExecutableFile
and Elem::ExecutableFile
. This will allows us to create a custom colors with a background.
What do you think of it?
from lsd.
That actually makes much more sense. I initially misunderstood how the Elem
enum works.
from lsd.
Another way to do it would be to make the File
variants of the Elem
and FileType
enums parametric:
enum Elem {
[…]
File {
uid: bool,
exec: bool
},
[…]
}
By adding SetuidFile
variants, we can replicate the behaviour of gnu ls, i.e. background red if suid, otherwise foreground green if executable, otherwise foreground white. But we cannot do a combination of foreground and background color because the file can only be a SetuidFile
or an ExecutableFile
.
from lsd.
Seems a great idea indeed. I think you can do the same thing with the directories.
from lsd.
Ok, then I’ll do it this way :)
from lsd.
Related Issues (20)
- [Bug]: lsd unicode characters not piped correctly in windows HOT 1
- [Bug]: All files from NTFS partition showing with green highlight HOT 1
- Truncate file names for a better looking grid list HOT 2
- Date formatted value doesn't work HOT 5
- Debian repo way out of date
- [Bug]: lsd 1.1.2 reporting 1.0.0? HOT 4
- [Bug]: Incorrectly shown icons after update HOT 1
- [Bug]: LSD not reading config.yaml HOT 5
- [Feature] Flag to show all blocks (columns), overriding config.yaml
- [Bug]: `lsd` has a different pipe behavior from `ls` HOT 3
- [Bug]: LSD -l permissions incorrect and user/group are both always "?"
- Names not aligned when using nerd font glyphs and Unicode emojis cusomization file HOT 1
- Tests fail on OpenBSD with Rust 1.78.0
- Feature request: NO_COLOR standard implementation
- compdef: unknown command or service: lsd HOT 2
- Lsd long output is not properly aligned HOT 13
- Hint states wrong --permission option HOT 2
- Colouring logic and other adaptations for Windows not applied under WSL HOT 2
- [Bug]: Incompatible behavior with `ls` with newlines HOT 2
- [Bug]: Main thread panics in a particular directory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsd.