Color the name with a red background if a setuid flag is set about lsd HOT 6 CLOSED

My idea would be to add a boolean parameter to the colorize function to control whether the background is highlighted or not. Is this acceptable, in your opinion?

from lsd.

I'm not a big fan of this kind of argument... What do you think of creating an Elem::SetuidFile and a FileType::SetuidFile like the Filetype::ExecutableFile and Elem::ExecutableFile. This will allows us to create a custom colors with a background.

What do you think of it?

from lsd.

That actually makes much more sense. I initially misunderstood how the Elem enum works.

from lsd.

Another way to do it would be to make the File variants of the Elem and FileType enums parametric:

enum Elem {
[…]
File {
    uid: bool,
    exec: bool
},
[…]
}

By adding SetuidFile variants, we can replicate the behaviour of gnu ls, i.e. background red if suid, otherwise foreground green if executable, otherwise foreground white. But we cannot do a combination of foreground and background color because the file can only be a SetuidFile or an ExecutableFile.

from lsd.

Seems a great idea indeed. I think you can do the same thing with the directories.

from lsd.

Ok, then I’ll do it this way :)

from lsd.