Comments (17)
@guillaumepotier @christianharke @slorber We are using react v15.6.1 and still had problems with this component in IE11.
I've successfully modified this component to use a MutationObserver with working IE11 support: e1-bsd/omni-common-ui@a6031f2
PLEASE NOTE that the onChange
signature is now different and takes the innerHTML directly. Patching the target
of the event no longer works as a MutationRecord
does not have a target
.
from react-contenteditable.
send pr for solving this. #44
from react-contenteditable.
@lovasoa I am looking for the IE support solution for this.
Here is a simple idea about solving this problem.
- use keyup event instead if IE browser.
- also handle paste event.
And you mentioned We can simply shadow the target if it can't be overwritten.
in here. Can you give me some hint about this? I'll make PR ASAP because my project need this support IE.
from react-contenteditable.
I don't know if this helps but on some React input components I use onInput
instead of onChange
so that IE11 behaves like all other browsers. Apparently onChange will work as expected in IE when Fiber a.k.a React v16.0 comes out.
from react-contenteditable.
@stahlmanDesign can you provide an example implementation of your solution please?
from react-contenteditable.
Replace onChange
with onInput
http://codepen.io/stahlmandesign/pen/JWpNKJ
from react-contenteditable.
@stahlmanDesign I don't understand, the project is about a contentEditable div, not a regular input.
Also onInput is already what is used: https://github.com/lovasoa/react-contenteditable/blob/master/src/react-contenteditable.js#L17
from react-contenteditable.
Hi there,
What is the status of this one, is this still an open issue for IE11?
Thanks
from react-contenteditable.
@guillaumepotier this is supposed to be resolved in React 15.6:
https://facebook.github.io/react/blog/2017/06/13/react-v15.6.0.html
facebook/react#8575
from react-contenteditable.
How, that's a good news! I'll test it then when I'll update it. Thanks for your help
from react-contenteditable.
@slorber I just updated to react 15.6.1, but unfortunately, the onChange prop function still doesn't get called in IE11. I hope I'm just doing something wrong...
from react-contenteditable.
@christianharke I'm not maintaining this project nor I have upgraded to 15.6.1, if you think it does not work try to reproduce with raw react div and if it does not work fill a bug in react repo
from react-contenteditable.
Seems to work fine now on React 16 in IE11.
Still broken...
from react-contenteditable.
I confirm this is still broken on IE11 with React and React-dom 1.16.3
Tested @notatestuser change and it works. Could we consider integrating it?
from react-contenteditable.
Is this repo still supported? Not working on IE 11 for me.
from react-contenteditable.
Yes, this repo is still maintained. I'd prefer not to merge @notatestuser PR because it breaks the current API. If onInput is not fired, then react should fix it. The issue was closed in react: if it is still present, then they should reopen it and fix it. Please go complain there :) facebook/react#7280
from react-contenteditable.
Hi there,
What is the status of this one, is this still an open issue for IE11?
Thanks
from react-contenteditable.
Related Issues (20)
- Switch to edit mode only on double click HOT 1
- When using Firefox and pressing enter, a <br> tag is added to the saved html HOT 1
- Custom components in html? HOT 1
- Retain caret position while dynamically changing the rendered html HOT 2
- cursor outside of block HOT 3
- expose props API to enable selection range get & set HOT 1
- auto height support
- vertical align center support as a props option HOT 3
- accept image
- Contenteditable should accept aria, for to accommodate label HOT 1
- ContentEditable' cannot be used as a JSX component HOT 4
- ability to set inputmode
- if ContentEditable in contenteditable="true", no trigger onChange HOT 1
- Is this component usable in Typescript?
- vim cursor popping up to top of view when hit escape
- how to set custom style in html HOT 1
- Getting caret line number.
- Enable passing custom value for active state
- Paste wont work some times.
- Content color is changing to red
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-contenteditable.