Giter Club home page Giter Club logo

Comments (12)

lovasoa avatar lovasoa commented on May 26, 2024 1

Oooh! I think I forgot to push the latest update to NPM!

from react-contenteditable.

WendellLiu avatar WendellLiu commented on May 26, 2024

I tried on React v15.3.1 but this warning didn't jump out.
The warning appeared only If I modify the code to pass html to div.

return React.createElement(
      this.props.tagName || 'div',
      {
        ...props,
        ref: (e) => this.htmlEl = e,
        onInput: this.emitChange,
        onBlur: this.props.onBlur || this.emitChange,
        onPaste: this.onPaste,
        contentEditable: !this.props.disabled,
        dangerouslySetInnerHTML: {__html: html},
        html // this line
      },
      this.props.children
    );

hope it's helpful

from react-contenteditable.

lovasoa avatar lovasoa commented on May 26, 2024

I'm not sure I understand... Of course, if you add html as a prop on a div, you get a warning. But why did you do that in the first place?

from react-contenteditable.

WendellLiu avatar WendellLiu commented on May 26, 2024

@lovasoa
You are talking about my example code?
If so, this example code just show the only way I can get the same warning. On the other hand, I can't get the same warning on the normal case.

from react-contenteditable.

lovasoa avatar lovasoa commented on May 26, 2024

Yes, so there is no warning, no problem. Why did you open this issue?

from react-contenteditable.

lovasoa avatar lovasoa commented on May 26, 2024

Oooh, sorry, I just realized it's not you who opened the issue! Sorry.

from react-contenteditable.

WendellLiu avatar WendellLiu commented on May 26, 2024

I just doubt that @mewben maybe did this mistake .

from react-contenteditable.

lovasoa avatar lovasoa commented on May 26, 2024

@mewben Do you see this warning with the latest react and latest react-contenteditable ?

from react-contenteditable.

mewben avatar mewben commented on May 26, 2024

Still getting the same error on a fresh install of create-react-app

node -v : v6.3.1
npm -v : 3.10.5
os: Mac

screen shot 2016-08-26 at 11 23 26 pm

from react-contenteditable.

lovasoa avatar lovasoa commented on May 26, 2024

Done! Sorry!

from react-contenteditable.

lovasoa avatar lovasoa commented on May 26, 2024

Please confirm that I can now close this issue :)

from react-contenteditable.

mewben avatar mewben commented on May 26, 2024

Thanks. closing now.

from react-contenteditable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.