Issues with Some.cs about language-ext HOT 2 CLOSED

First change: The overrides which call CheckInitialized ...

Yep, some silly mistakes there. I've taken a different approach to fixing it:

        public T Value => 
            CheckInitialised(value);

        public static implicit operator T(Some<T> value) => 
            value.Value;

        public override string ToString() =>
            Value.ToString();

        public override int GetHashCode() =>
            Value.GetHashCode();

        public override bool Equals(object obj) =>
            Value.Equals(obj);

It puts slightly more burden on the Value access, but I think overall it's cleaner.

For performance reasons, the CLR will not call the default constructor on struct arrays.

It's not the CLR, it's the C# compiler. It could easily call the same series of op-codes that it does for classes. It is however (like you say) an optimisation. I believe the C# team are discussing default constructors for the final C# 6. So we'll see how that goes. Until then Some<T> will always be a weak solution to this problem.

I do discuss this on the project home page, and explain its limitations. I think only using Some<T> for method arguments, and never instantiating them manually is probably the best use of a weak solution.

Thanks for the heads up on the bugs!

from language-ext.

No problem -- I like the way you handled everything, I think that makes it work out nicely. Closing this issue now.

from language-ext.