Did I successfully suggest changes? about lost-stats.github.io HOT 11 CLOSED

That should work fine! Are the changes showing up on the live site?

from lost-stats.github.io.

from lost-stats.github.io.

Hmm, that's weird. Actually, now that I think of it, I thought you were talking about the "Edit this page on Github" link at the bottom of each page. I'm not familiar with the "Propose changes" button

from lost-stats.github.io.

from lost-stats.github.io.

Hmm, maybe! Check if there's a LOST fork on your account. I don't see it as a pull request.

I wonder if maybe you're pushing changes to the Master branch rather htan the Source branch by accident. If that's the case, your edits would be overridden every time it remakes the website, since it takes the Source files and builds the site in Master

from lost-stats.github.io.

Hmm so I think I found this fork of mine - maybe my changes are there?: https://github.com/clibassi/lost-stats.github.io

Also if it's at all helpful, here's what I see when I go to make edits:

from lost-stats.github.io.

Could be, but the last commit on that fork is from January of last year so it doesn't seem likely.

I'd have expected that a "Propose changes" button would make a pull request but I don't see any from you. I'm just not familiar with the Propose system. @khwilson do you have any idea how this works?

from lost-stats.github.io.

Thanks to the github support community I think I figured out how to submit a PR. Once I get confirmation on your end, we can close this issue, I think.

from lost-stats.github.io.

Looks like it's working now!

from lost-stats.github.io.

from lost-stats.github.io.

Yep, fine now

from lost-stats.github.io.