Giter Club home page Giter Club logo

Comments (12)

 avatar commented on June 12, 2024

@kode54 Thanks for the implementation. The shuffle part works, however, it doesn't get properly activated.

If "Shuffle Albums" is disabled when Cog is launched with a couple of albums loaded into the playlist, and we activate the option, it skips to a random album right after the first album song finishes, instead of completing the album.

Update: Seems to be fixed by 2ad9584.

If "Shuffle Albums" is already enabled when Cog is launched with a couple of albums loaded into the playlist, the shuffle doesn't get activated at all and it just plays the albums in order. However, within the same session, if we deactivate and reactivate the option, the shuffle works as intended.

from cog.

 avatar commented on June 12, 2024

To test it, just use the "Next Track" shortcut key, instead of having to wait for full song playback.

from cog.

kode54 avatar kode54 commented on June 12, 2024

This is already known. It doesn't even build the shuffle playlist until you activate shuffle, and it doesn't consider any tracks that were already queued or playing when creating the shuffle playlist. Otherwise, it would need to manually exclude the current album and add it first. I'll look into that later.

Unless, you know, you'd like to contribute some code now. That would be great too. :D

from cog.

 avatar commented on June 12, 2024

It seems that with the latest version all the commits regarding this got reverted. Shuffle albums is no longer working.

from cog.

kode54 avatar kode54 commented on June 12, 2024

Sorry about that, I had to fix it for real this time. It was by sheer luck that it even worked at all the first time.

from cog.

 avatar commented on June 12, 2024

If "Shuffle Albums" is already enabled when Cog is launched with a couple of albums loaded into the playlist, the shuffle doesn't get activated at all and it just plays the albums in order. However, within the same session, if we deactivate and reactivate the option, the shuffle works as intended.

Just for peace of mind, is there a way for Cog to detect if Shuffle Albums is already enabled on launch (like it does for Shuffle Tracks) and enforce the shuffling after all metadata is retrieved?
If not, I'll just close this and manually toggle it each time.

from cog.

kode54 avatar kode54 commented on June 12, 2024

All metadata is supposed to be retrieved when you add the files, and is cached on disk until the files are removed from the playlist.

from cog.

 avatar commented on June 12, 2024

Yes, but "Shuffle Albums" only works if activated manually after all metadata has populated the playlist (we have to wait before activating the option). Enabling the shuffle manually before all metadata has been retrieved or quitting Cog with the Shuffle enabled and reopening some files won't activate the shuffle.

That was my question really, because it differs from the shuffle tracks option. I haven't tried but I assume the repeat options are also applied if already enabled on launch,

from cog.

 avatar commented on June 12, 2024

Anyway, I'll toggle the option each time i need it. If you feel it could be improved, I know it will come up on a future update. Thanks again and cheers.

from cog.

kode54 avatar kode54 commented on June 12, 2024

Sorry it doesn't work as expected. It also doesn't work that well when the playlist has been modified after it is generated. I didn't design the original shuffle thing.

from cog.

 avatar commented on June 12, 2024

It's quite improved as it is and thanks for that. The original version didn't even have the album shuffle implemented at all which you tackled quite nicely.

from cog.

kode54 avatar kode54 commented on June 12, 2024

And as a bare minimum of making it work, I also designed it so that when you start any album manually, it pushes it to the top of the shuffle queue, so that it will play out that album first before beginning whatever else is in the queue.

from cog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.