Giter Club home page Giter Club logo

Comments (3)

meandmax avatar meandmax commented on July 20, 2024

@Dangoo,

I removed all eventlisteners, and as far as I can see all listeners are gone. Hope this helped.

thx Max

from lory.

rjoo avatar rjoo commented on July 20, 2024

Any chance this can be reopened?

Calling destroy on a lory instance doesn't actually remove the inline styles. Unless I'm missing something. Example:

transition-duration: 0ms; transform: translate3d(-435px, 0px, 0px); transition-timing-function: ease;

from lory.

rjoo avatar rjoo commented on July 20, 2024

After actually looking in the source, I confirmed the suspicion that nothing removes the added styles in the destroy method.

Adding a simple method and calling it when destroyed seems to take care of it.

function untranslate () {
    const style = slideContainer && slideContainer.style;

    if (style) {
        style[prefixes.transition + 'TimingFunction'] = null;
        style[prefixes.transition + 'Duration'] = null;
        style[prefixes.transform] = null;
    }
}

// ...

function destroy () {
    dispatchSliderEvent('before', 'destroy');

    untranslate();
    // ...

from lory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.