infinite with slidesToScroll > 1 is broken about lory HOT 13 CLOSED

http://codepen.io/nstanard/pen/kkvXao?editors=1010
http://codepen.io/nstanard/pen/yaKxzK?editors=0010

You have slides to scroll set to 4 with 9 slides... I don't believe the example you provide is an issue.

It slides four at a time as it should. Perhaps I'm not understanding what you are trying to point out?

from lory.

@haggen Thoughts?

from lory.

I do believe this is an issue, having come across it myself today.

EDIT - please see below comment.

from lory.

@liam-potter Can you put together an example on codepen? I'm totally willing to help but I'm not following the description provided.

from lory.

http://codepen.io/anon/pen/EgpwLJ

Given a starting state of slides 1, 2 and 3 being visible:

• The first swipe correctly shows slides 4, 5 and 1. The expected behaviour when swiping again would be to show 2, 3 and 4. Instead it resets to 1, 2 and 3 (and it is no longer possible to swipe).
• If you start again and swipe in the opposite direction it correctly shows 3, 4 and 5. Swiping again correctly shows 5, 1 and 2. The expected behaviour when swiping once more would be to show 2, 3 and 4 but instead it resets to 3, 4 and 5 (it is still possible to swipe).

Please ignore my earlier comment.

from lory.

With regards to my earlier comment (I've removed it as it wasn't clear), this was only applicable if the user was using infinite: 3 and slidesToScroll: 1 - this appears to work fine.

The actual issue is as I have detailed in the above codepen - i.e. using infinite: 3 and slidesToScroll: 3 when the actual number of slides is not divisible by 3.

from lory.

Thank you for providing an example. I will take a closer look tomorrow.

from lory.

@nstanard any updates on this issue? i can't get infinite to work at all. it will loop infinitely, but no matter what number i set it to, it only displays one image at a time.

from lory.

I fell off the face of the earth for a while. But I'm back now. I apologize for the lack of activity. I'll have to start slotting out time to work through issues on this project. However, I'm of the mindset right now that I'd rather start on Lory 2.0. We'll see how this plays out over the next few months.

from lory.

I've moved on to a new solution I've developed myself. My needs was of only a subset of the features generally available in carousels and sliders, also I didn't have to support older browsers so I thought it was a good fit. https://codepen.io/haggen/pen/PzJvaB

from lory.

@haggen Hey that looks great! It's always nice to be able to use a smaller sized piece of JS to get what you need. ;)

from lory.

Hi @nstanard,

Love Lory, it's so buttery smooth.
However, I am having the same issue as is documented above. If infinite and slides to scroll are set, but the slide set is not a multiple of the slides to scroll then the infinite breaks.

Examples;
16 slides - Infinite/StS 3: 16/3 = 5.33 and breaks
52 slides - Infinite/StS 8: 52/8 = 6.5 and breaks

Do you have any ETA on a fix for this in 1.0 or a release date for 2.0 planned?
The smoothness of Lory is unbeatable, but we'd like to move more than one slide at a time.

from lory.

Hello @meandmax

I see a regression with your commit.
Now, I can't use this setup:

{
  infinite: 4,
  slideToScroll: 1,
}

Since you make some calculations like index + (infinite * 2) !== slides.length
and not index + (slideToScroll * 2) !== slides.length for example, whatever my config, it force to slide many by many (4 by 4 in my setup) except for the slide translation if my slider doesn't contain a multiple of 4.

I try with the previous version (2.4.4) and it reworks again.
In the setup, it may need a bypass like infinite >= slideToScroll and so force the value + add a log to the user?

Thanks,

from lory.