Tests in IE failing on Travis CI about lory HOT 8 CLOSED

@meandmax IE 9 doesn't support classList. This polyfill did the trick.

from lory.

Depending on how much you value IE9 support, you could replace the problem lines with classList-less functions.

I've got some experience with this and can open a PR if that'd be easier.

from lory.

Hey @tshedor,

thanks for the help!

As you can see in "saucelabs.karma.conf.js" I already integrated this polyfill for the tests, and it worked so before I implemented async tests which actually measure the current offset of the slider or am I doing anything wrong?

   files: [
            'dist/lory.js',
            'test/lory.test.js',
            'demo/app.css',
            'http://cdnjs.cloudflare.com/ajax/libs/classlist/2014.01.31/classList.min.js',

            {
                pattern: 'test/*.html'
            }
        ],

Thanks a lot for investing some time!
Max

from lory.

And actually there are just 7 tests which fail in the IE9, the rest works so far. If there would be a problem with classlist, then all tests in IE9 would fail or what do you think?

Max

from lory.

Yeah, that's a good point - they would all fail if it was classList. I'll try this in a VM.

from lory.

All seven of those tests include the waitForTransitionEnd callback - I wonder if it's having a hard time with the && in done && done()?

from lory.

I will give it a shot!

from lory.

#153

deactivated the tests in IE9 temp. ... if anybody has an idea, feel free!

Max

from lory.