Unhandled Exception: [WinError 267] Directory name invalid about safaribooks HOT 9 CLOSED

Some books have the same short book name on safaribooks.

from safaribooks.

I fixed this issue! Thanks again!
But I don't understand the last comment. What do you mean?

from safaribooks.

Some books have the same short book name on safaribooks.

For example,the following two books have the same short name: Stepping Up

https://www.safaribooksonline.com/library/view/stepping-up/9781292186887/
https://www.safaribooksonline.com/library/view/stepping-up/9781609940584/

from safaribooks.

Ok, with the last commit I fixed this problem.
Thanks for helping me!

from safaribooks.

def escape_dirname(dirname, clean_space=False):
if ":" in dirname:
if dirname.index(":") > 30:
dirname = dirname.split(":")[0]

    for ch in ['\\', '/', '<', '>', '`', '\'', '"', '*', '?', '|']:
        if ch in dirname:
            dirname = dirname.replace(ch, "")

    return dirname if not clean_space else dirname.replace(" ", "")

this Statement maybe wrong，not 30 but 0
if dirname.index(":") > 30:

from safaribooks.

I voluntarily put 30 because I want to split only long titles.
Example: there is a book called "HTTP: The Definitive Guide". It's ok for me to display all the book title.
But I can't say the same for a book like "Windows Internals, Part 1: System architecture, processes, threads, memory management, and more, Seventh Edition".
Maybe I have to reduce the range...

from safaribooks.

Now is 15 chars

from safaribooks.

def escape_dirname(dirname, clean_space=False):
if ":" in dirname and dirname.index(":") > 15:
dirname = dirname.split(":")[0]

    for ch in ['\\', '/', '<', '>', '`', '\'', '"', '*', '?', '|']:
        if ch in dirname:
            dirname = dirname.replace(ch, "")

    return dirname if not clean_space else dirname.replace(" ", "")

Running on Windows system, dirname cannot include ":“.

for ch in ['\', '/', '<', '>', '`', ''', '"', '*', '?', '|', ':']:
if ch in dirname:
dirname = dirname.replace(ch, "")

from safaribooks.

I always use Linux, so I don't cover well the problems on Windows.
I updated the program adding this fix.

from safaribooks.