Giter Club home page Giter Club logo

Comments (2)

Ortham avatar Ortham commented on September 16, 2024

I'm going to undo the change to GameInterface::GetPlugin(), as std::shared_ptr<> already handles the null state effectively, and usage in the LOOT application has shown that wrapping it in an optional doesn't provide any benefits, it just creates extra work.

I'm also flip-flopping on DatabaseInterface::GetPluginMetadata() and DatabaseInterface::GetPluginUserMetadata(), as optionals overlap with PluginMetadata::HasNameOnly(), which when true means there's a metadata object that contains no metadata. Unfortunately this is a valid state as the metadata files may have an entry with only a name field, unless that becomes invalid syntax, so HasNameOnly() needs to stay and you end up having to check if the optional is nullopt and is HasNameOnly() is true.

from libloot.

Ortham avatar Ortham commented on September 16, 2024

Done as of 1fe8f90.

from libloot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.